Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: runtime/observatory/lib/src/elements/vm_connect.dart

Issue 2211603002: Centralized event streams (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Updated observatory_sources Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/vm_connect.dart
diff --git a/runtime/observatory/lib/src/elements/vm_connect.dart b/runtime/observatory/lib/src/elements/vm_connect.dart
index 8539921608b9b833193bb0eec9848d351614262d..c101efabc7b90d6c2db10c21a7fd90b731cacf36 100644
--- a/runtime/observatory/lib/src/elements/vm_connect.dart
+++ b/runtime/observatory/lib/src/elements/vm_connect.dart
@@ -16,6 +16,8 @@ import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/view_footer.dart';
import 'package:observatory/src/elements/vm_connect_target.dart';
+typedef void CrashDumpLoadCallback(Map dump);
+
class VMConnectElement extends HtmlElement implements Renderable{
static const tag = const Tag<VMConnectElement>('vm-connect',
dependencies: const [NavBarElement.tag,
@@ -28,7 +30,7 @@ class VMConnectElement extends HtmlElement implements Renderable{
Stream<RenderedEvent<VMConnectElement>> get onRendered => _r.onRendered;
- M.CrashDumpRepository _dump;
+ CrashDumpLoadCallback _loadDump;
M.NotificationRepository _notifications;
M.TargetRepository _targets;
StreamSubscription _targetsSubscription;
@@ -36,17 +38,17 @@ class VMConnectElement extends HtmlElement implements Renderable{
String _address;
factory VMConnectElement(M.TargetRepository targets,
- M.CrashDumpRepository dump,
+ CrashDumpLoadCallback loadDump,
M.NotificationRepository notifications,
{String address: '', RenderingQueue queue}) {
assert(address != null);
- assert(dump != null);
+ assert(loadDump != null);
assert(notifications != null);
assert(targets != null);
VMConnectElement e = document.createElement(tag.name);
e._r = new RenderingScheduler(e, queue: queue);
e._address = address;
- e._dump = dump;
+ e._loadDump = loadDump;
e._notifications = notifications;
e._targets = targets;
return e;
@@ -156,7 +158,7 @@ class VMConnectElement extends HtmlElement implements Renderable{
reader.readAsText(e.files[0]);
reader.onLoad.listen((_) {
var crashDump = JSON.decode(reader.result);
- _dump.load(crashDump);
+ _loadDump(crashDump);
});
});
return e;

Powered by Google App Engine
This is Rietveld 408576698