Centralized event streams

runtime/observatory/lib/src/models/objects/event.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file

[turnidge, 2016/08/04 18:16:36]

Do you see us eventually pushing this Event class hierarchy into
service/object.dart?

[cbernaschina, 2016/08/04 21:00:20]

I think that will be possible.
I think, though, that the best solution is to separate it into two CLs.
Once this layer of abstraction is in place integrate it into the service object
will be a non breaking change for the UI.

 
 part of models;
 
 abstract class Event {
   DateTime get timestamp;
   static bool isPauseEvent(Event event) {
     return event is PauseStartEvent || event is PauseExitEvent ||
         event is PauseBreakpointEvent || event is PauseInterruptedEvent ||
         event is PauseExceptionEvent || event is NoneEvent;
   }
 }
 abstract class VMEvent extends Event {
   VMRef get vm;
 }
 abstract class VMUpdateEvent extends VMEvent {}
 abstract class IsolateEvent extends Event {
   IsolateRef get isolate;
 }
 abstract class IsolateStartEvent extends IsolateEvent {}
 abstract class IsolateRunnableEvent extends IsolateEvent {}
 abstract class IsolateExitEvent extends IsolateEvent {}
 abstract class IsolateUpdateEvent extends IsolateEvent {}

[turnidge, 2016/08/04 18:16:36]

Blank line between classes please, here and elsewhere.

[cbernaschina, 2016/08/04 21:00:20]

Done.

 abstract class IsolateReloadEvent extends IsolateEvent {
   ErrorRef get error;
 }
 abstract class ServiceExtensionAddedEvent extends IsolateEvent {
   String get extensionRPC;
 }
-abstract class DebugEvent extends IsolateEvent {}
+abstract class DebugEvent extends Event {
+  IsolateRef get isolate;
+}
+abstract class DebuggerSettingsUpdateEvent extends DebugEvent {}
 abstract class PauseStartEvent extends DebugEvent {}
 abstract class PauseExitEvent extends DebugEvent {}
 abstract class PauseBreakpointEvent extends DebugEvent {
   /// [optional]
   Breakpoint get breakpoint;
   Iterable<Breakpoint> get pauseBreakpoints;
   Frame get topFrame;
   bool get atAsyncSuspension;
 }
 abstract class PauseInterruptedEvent extends DebugEvent {
@@ skipping 11 matching lines @@
 abstract class BreakpointResolvedEvent extends DebugEvent {
   Breakpoint get breakpoint;
 }
 abstract class BreakpointRemovedEvent extends DebugEvent {
   Breakpoint get breakpoint;
 }
 abstract class InspectEvent extends DebugEvent {
   InstanceRef get inspectee;
 }
 abstract class NoneEvent extends DebugEvent {}
-abstract class GCEvent extends IsolateEvent {}
+abstract class GCEvent extends Event {
+  IsolateRef get isolate;
+}
 abstract class ExtensionEvent extends Event {
   IsolateRef get isolate;
   String get extensionKind;
   ExtensionData get extensionData;
 }
-abstract class TimelineEventsEvent extends IsolateEvent {
+abstract class TimelineEventsEvent extends Event {
+  IsolateRef get isolate;
   Iterable<TimelineEvent> get timelineEvents;
 }
 abstract class ConnectionClosedEvent extends Event {
   String get reason;
 }