Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2211563002: Use Point<num> in dart:html for strong mode (Closed)

Created:
4 years, 4 months ago by Jacob
Modified:
4 years, 4 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use Point<num> in dart:html for strong mode Strong mode is (as of recently) inferring a stricter type (e.g., Point<double>) and causing breaking changes. patch from issue 2211493003 at patchset 1 (http://crrev.com/2211493003#ps1) BUG= Committed: https://github.com/dart-lang/sdk/commit/36c9514f049d057285d407a44df798218f70d47e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -67 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 7 chunks +20 lines, -20 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 7 chunks +21 lines, -21 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_MouseEvent.darttemplate View 3 chunks +7 lines, -7 lines 0 comments Download
M tools/dom/templates/html/dartium/impl_MouseEvent.darttemplate View 2 chunks +6 lines, -6 lines 0 comments Download
M tools/dom/templates/html/impl/impl_ClientRect.darttemplate View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DOMRectReadOnly.darttemplate View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Touch.darttemplate View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Jacob
TBR. Version of your CL with html_dart2js, etc.
4 years, 4 months ago (2016-08-03 21:08:53 UTC) #2
Jacob
4 years, 4 months ago (2016-08-03 21:09:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
36c9514f049d057285d407a44df798218f70d47e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698