Remove SearchTabHelper::IsSearchResultsPage

Remove SearchTabHelper::IsSearchResultsPage
It was confusingly named: It only refers to search pages rendered in the Instant process, which is an abandoned feature, so in practice it always returns false.

BUG=627747
Committed: https://crrev.com/7943ceeef722036f20a2c2da02bc4ebfa62a31a0
Cr-Commit-Position: refs/heads/master@{#411597}

[Marc Treib, 2016-08-04 10:25:59]

treib@chromium.org changed reviewers:
+ sfiera@chromium.org

[Marc Treib, 2016-08-04 10:26:00]

PTAL!

[sfiera, 2016-08-04 11:15:30]

I see no problems with the code, but I don't know enough about instant and
prerendering to really evaluate the change. If you think this merits a
rubberstamp, I can do that.

[Marc Treib, 2016-08-04 11:58:03]

On 2016/08/04 11:15:30, sfiera wrote:
> I see no problems with the code, but I don't know enough about instant and
> prerendering to really evaluate the change. If you think this merits a
> rubberstamp, I can do that.

I thought this warranted a rubberstamp, but the failing test means it does need
more investigation...

[Marc Treib, 2016-08-05 09:45:40]

On 2016/08/04 11:58:03, Marc Treib wrote:
> On 2016/08/04 11:15:30, sfiera wrote:
> > I see no problems with the code, but I don't know enough about instant and
> > prerendering to really evaluate the change. If you think this merits a
> > rubberstamp, I can do that.
> 
> I thought this warranted a rubberstamp, but the failing test means it does
need
> more investigation...

Okay, turns out the failing test is part of another dead feature, and will
hopefully be removed soon (https://codereview.chromium.org/2211983002/).
I'll just wait for that to land, and then get back to you about that rubberstamp
:)

[Marc Treib, 2016-08-12 10:22:38]

On 2016/08/05 09:45:40, Marc Treib wrote:
> On 2016/08/04 11:58:03, Marc Treib wrote:
> > On 2016/08/04 11:15:30, sfiera wrote:
> > > I see no problems with the code, but I don't know enough about instant and
> > > prerendering to really evaluate the change. If you think this merits a
> > > rubberstamp, I can do that.
> > 
> > I thought this warranted a rubberstamp, but the failing test means it does
> need
> > more investigation...
> 
> Okay, turns out the failing test is part of another dead feature, and will
> hopefully be removed soon (https://codereview.chromium.org/2211983002/).
> I'll just wait for that to land, and then get back to you about that
rubberstamp
> :)

Now https://codereview.chromium.org/2211983002/ has landed, I think this is
ready for that rubberstamp :)

[sfiera, 2016-08-12 10:23:49]

LGTM

[Marc Treib, 2016-08-12 10:30:07]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-08-12 10:30:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 11:41:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-12 11:43:12]

Description was changed from

==========
Remove SearchTabHelper::IsSearchResultsPage
It was confusingly named: It only refers to search pages rendered in the Instant
process, which is an abandoned feature, so in practice it always returns false.

BUG=627747
==========

to

==========
Remove SearchTabHelper::IsSearchResultsPage
It was confusingly named: It only refers to search pages rendered in the Instant
process, which is an abandoned feature, so in practice it always returns false.

BUG=627747

Committed: https://crrev.com/7943ceeef722036f20a2c2da02bc4ebfa62a31a0
Cr-Commit-Position: refs/heads/master@{#411597}
==========

[commit-bot: I haz the power, 2016-08-12 11:43:13]

Patchset 2 (id:??) landed as
https://crrev.com/7943ceeef722036f20a2c2da02bc4ebfa62a31a0
Cr-Commit-Position: refs/heads/master@{#411597}