Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 221153002: [DirectWrite] Set minimum anti-aliased font size on a per script basis (Closed)

Created:
6 years, 8 months ago by eae
Modified:
6 years, 8 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

[DirectWrite] Set minimum anti-aliased font size on a per script basis Change FontCacheSkiaWin to set the minimum font size for anti aliasing on a per script basis and assign min sizes for Han, Hiragana, Katakana, Hangul, and Bengali. The current values where chosen by picking the minimum value for which Wikipedia in said script was legible and will likely require further tweaking based on user input. R=dglazkov@chromium.org BUG=357864 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170608

Patch Set 1 #

Patch Set 2 : Remove FIXME #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -29 lines) Patch
M Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 3 chunks +37 lines, -29 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
eae
6 years, 8 months ago (2014-04-01 16:41:32 UTC) #1
eae
Ready for review.
6 years, 8 months ago (2014-04-01 17:52:12 UTC) #2
dglazkov
lgtm
6 years, 8 months ago (2014-04-01 18:23:33 UTC) #3
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-04-01 19:31:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/221153002/20001
6 years, 8 months ago (2014-04-01 19:31:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 19:45:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-01 19:45:29 UTC) #7
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-04-01 20:52:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/221153002/20001
6 years, 8 months ago (2014-04-01 20:52:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/221153002/20001
6 years, 8 months ago (2014-04-01 22:23:46 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 23:51:06 UTC) #11
Message was sent while issue was closed.
Change committed as 170608

Powered by Google App Engine
This is Rietveld 408576698