Add test for bug 620428 (setinterval cancellation)

Add test for bug 620428 (setinterval cancellation)

While we're at it, beef up existing test for non-cancellation.
In turn, fix test harness to implement intervals properly.
In turn, fix public documentation to be clearer about timers.

Also rename a few identifiers that sounded "off".

Committed: https://pdfium.googlesource.com/pdfium/+/8e12029407cf1cca95b7f79bf5e5a5fec5bea9cb

[Tom Sepez, 2016-08-03 20:17:50]

Description was changed from

==========
Add test for bug 620428 (setinterval cancellation)

While we're at it, beef up existing test for non-cancellation.
In turn, fix test harness to implement intervals properly.
In turn, fix public docmentation to be clearer about timers.
==========

to

==========
Add test for bug 620428 (setinterval cancellation)

While we're at it, beef up existing test for non-cancellation.
In turn, fix test harness to implement intervals properly.
In turn, fix public documentation to be clearer about timers.

Also rename a few identifiers that sounded "off".
==========

[Tom Sepez, 2016-08-03 20:18:33]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 20:18:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-03 20:22:50]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-08-03 20:22:51]

Lei, for review.

[Tom Sepez, 2016-08-03 20:35:15]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 20:35:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-03 20:35:47]

On 2016/08/03 20:22:51, Tom Sepez wrote:
> Lei, for review.

Srry, PS6 should be good. Thanks.

[Lei Zhang, 2016-08-03 20:36:52]

lgtm

https://codereview.chromium.org/2211513002/diff/80001/fpdfsdk/fpdfformfill_em...
File fpdfsdk/fpdfformfill_embeddertest.cpp (right):

https://codereview.chromium.org/2211513002/diff/80001/fpdfsdk/fpdfformfill_em...
fpdfsdk/fpdfformfill_embeddertest.cpp:117: EXPECT_NE(nullptr, page);
Do EXPECT_TRUE() like line 75?

https://codereview.chromium.org/2211513002/diff/80001/fpdfsdk/fpdfformfill_em...
fpdfsdk/fpdfformfill_embeddertest.cpp:119: delegate.AdvanceTime(1000);
Does this behaves different vs delegate.AdvanceTime(5000) ? Maybe add a comment?

[Tom Sepez, 2016-08-03 20:43:31]

https://codereview.chromium.org/2211513002/diff/80001/fpdfsdk/fpdfformfill_em...
File fpdfsdk/fpdfformfill_embeddertest.cpp (right):

https://codereview.chromium.org/2211513002/diff/80001/fpdfsdk/fpdfformfill_em...
fpdfsdk/fpdfformfill_embeddertest.cpp:117: EXPECT_NE(nullptr, page);
On 2016/08/03 20:36:52, Lei Zhang wrote:
> Do EXPECT_TRUE() like line 75?

Done throughout.

https://codereview.chromium.org/2211513002/diff/80001/fpdfsdk/fpdfformfill_em...
fpdfsdk/fpdfformfill_embeddertest.cpp:119: delegate.AdvanceTime(1000);
On 2016/08/03 20:36:52, Lei Zhang wrote:
> Does this behaves different vs delegate.AdvanceTime(5000) ? Maybe add a
comment?

Kinda sorta.  The clumsy test harness doesn't schedule timers based on absolute
time, but rather the delta from when they last fired. So a given timer will only
fire once per AdvanceTime(), thus avoiding an endless loop if something gets
botched.  Close enough.

A single call is fine here.

[Tom Sepez, 2016-08-03 20:44:07]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-08-03 20:44:08]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2211513002/#ps140001
(title: "EXPECT_TRUE is simpler")

[commit-bot: I haz the power, 2016-08-03 20:44:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:03:39]

Description was changed from

==========
Add test for bug 620428 (setinterval cancellation)

While we're at it, beef up existing test for non-cancellation.
In turn, fix test harness to implement intervals properly.
In turn, fix public documentation to be clearer about timers.

Also rename a few identifiers that sounded "off".
==========

to

==========
Add test for bug 620428 (setinterval cancellation)

While we're at it, beef up existing test for non-cancellation.
In turn, fix test harness to implement intervals properly.
In turn, fix public documentation to be clearer about timers.

Also rename a few identifiers that sounded "off".

Committed:
https://pdfium.googlesource.com/pdfium/+/8e12029407cf1cca95b7f79bf5e5a5fec5be...
==========

[commit-bot: I haz the power, 2016-08-03 21:03:40]

Committed patchset #8 (id:140001) as
https://pdfium.googlesource.com/pdfium/+/8e12029407cf1cca95b7f79bf5e5a5fec5be...