Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2211493003: Use Point<num> in dart:html for strong mode

Created:
4 years, 4 months ago by vsm
Modified:
4 years, 4 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org, Jennifer Messerly, Leaf
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use Point<num> in dart:html for strong mode Strong mode is (as of recently) inferring a stricter type (e.g., Point<double>) and causing breaking changes.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M tools/dom/templates/html/dart2js/impl_MouseEvent.darttemplate View 3 chunks +7 lines, -7 lines 0 comments Download
M tools/dom/templates/html/dartium/impl_MouseEvent.darttemplate View 2 chunks +6 lines, -6 lines 0 comments Download
M tools/dom/templates/html/impl/impl_ClientRect.darttemplate View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DOMRectReadOnly.darttemplate View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Touch.darttemplate View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
vsm
4 years, 4 months ago (2016-08-03 20:54:21 UTC) #3
Jacob
4 years, 4 months ago (2016-08-03 20:57:38 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698