net/http/transport_security_persister_unittest.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/transport_security_persister_unittest.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/audio/win/audio_low_latency_input_win_unittest.cc ('K') | « net/dns/mdns_client_unittest.cc ('k') | net/test/spawned_test_server/local_test_server_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/transport_security_persister_unittest.cc

diff --git a/net/http/transport_security_persister_unittest.cc b/net/http/transport_security_persister_unittest.cc

index 5809c92719f223075c1eb6511dc9d4f6fe0ee042..78459cccf60af2c0b62213a289839f7c26c287bf 100644

--- a/net/http/transport_security_persister_unittest.cc

+++ b/net/http/transport_security_persister_unittest.cc

@@ -13,6 +13,7 @@

#include "base/files/file_util.h"

#include "base/files/scoped_temp_dir.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "net/http/transport_security_state.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -27,9 +28,7 @@ class TransportSecurityPersisterTest : public testing::Test {

TransportSecurityPersisterTest() {

}

- ~TransportSecurityPersisterTest() override {

- base::MessageLoopForIO::current()->RunUntilIdle();

- }

+ ~TransportSecurityPersisterTest() override { base::RunLoop().RunUntilIdle(); }

gab 2016/08/05 01:09:57 Missing DCHECK ForIO

fdoray 2016/08/05 16:10:36 Done.

void SetUp() override {

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());