chrome/browser/first_run/try_chrome_dialog_view.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/try_chrome_dialog_view.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/message_loop/message_loop_unittest.cc ('K') | « chrome/browser/download/download_path_reservation_tracker_unittest.cc ('k') | chrome/browser/importer/edge_importer_browsertest_win.cc » ('j') | components/suggestions/suggestions_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/first_run/try_chrome_dialog_view.cc

diff --git a/chrome/browser/first_run/try_chrome_dialog_view.cc b/chrome/browser/first_run/try_chrome_dialog_view.cc

index da3f29ce4830eaa4147b99486ee7bf92417959c3..dd757f36182ec9878de823edec6b4738945082b6 100644

--- a/chrome/browser/first_run/try_chrome_dialog_view.cc

+++ b/chrome/browser/first_run/try_chrome_dialog_view.cc

@@ -9,6 +9,7 @@

#include "base/logging.h"

#include "base/macros.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/strings/string16.h"

#include "chrome/browser/process_singleton.h"

#include "chrome/grit/chromium_strings.h"

@@ -288,7 +289,7 @@ TryChromeDialogView::Result TryChromeDialogView::ShowModal(

popup_->Show();

if (!listener.is_null())

listener.Run(popup_->GetNativeView());

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

if (!listener.is_null())

listener.Run(NULL);

return result_;