blimp/client/core/contents/blimp_contents_impl_unittest.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/blimp_contents_impl_unittest.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/message_loop/message_loop_unittest.cc ('K') | « base/win/object_watcher_unittest.cc ('k') | blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc » ('j') | components/suggestions/suggestions_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/contents/blimp_contents_impl_unittest.cc

diff --git a/blimp/client/core/contents/blimp_contents_impl_unittest.cc b/blimp/client/core/contents/blimp_contents_impl_unittest.cc

index 555cbbe913ac298c31c00076895fe6a27a81a2c3..0a12cdcd34e5f8799184485e7d34b43ac737672b 100644

--- a/blimp/client/core/contents/blimp_contents_impl_unittest.cc

+++ b/blimp/client/core/contents/blimp_contents_impl_unittest.cc

@@ -5,6 +5,7 @@

#include "blimp/client/core/contents/blimp_contents_impl.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "blimp/client/core/contents/blimp_contents_impl.h"

#include "blimp/client/core/contents/fake_navigation_feature.h"

#include "blimp/client/public/contents/blimp_contents_observer.h"

@@ -48,7 +49,7 @@ TEST(BlimpContentsImplTest, LoadURLAndNotifyObservers) {

EXPECT_CALL(observer2, OnNavigationStateChanged()).Times(2);

navigation_controller.LoadURL(GURL(kExampleURL));

- loop.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_EQ(kExampleURL, navigation_controller.GetURL().spec());

@@ -56,7 +57,7 @@ TEST(BlimpContentsImplTest, LoadURLAndNotifyObservers) {

blimp_contents.RemoveObserver(&observer1);

navigation_controller.LoadURL(GURL(kOtherExampleURL));

- loop.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_EQ(kOtherExampleURL, navigation_controller.GetURL().spec());

}