chrome/browser/ui/panels/base_panel_browser_test.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/base_panel_browser_test.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc ('k') | chrome/browser/ui/panels/panel_browsertest.cc » ('j') | components/sync/tools/testserver/run_sync_testserver.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/base_panel_browser_test.cc

diff --git a/chrome/browser/ui/panels/base_panel_browser_test.cc b/chrome/browser/ui/panels/base_panel_browser_test.cc

index 10ffeb0e69ff0bda18ed3068d11141ee92f31b23..fd31074c7be523772a337b3f8bfae85146106895 100644

--- a/chrome/browser/ui/panels/base_panel_browser_test.cc

+++ b/chrome/browser/ui/panels/base_panel_browser_test.cc

@@ -11,6 +11,7 @@

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/strings/string_number_conversions.h"

#include "build/build_config.h"

#include "chrome/browser/chrome_notification_types.h"

@@ -362,7 +363,8 @@ Panel* BasePanelBrowserTest::CreatePanelWithParams(

}

if (params.wait_for_fully_created) {

- base::MessageLoopForUI::current()->RunUntilIdle();

+ DCHECK(base::MessageLoopForUI::IsCurrent());

+ base::RunLoop().RunUntilIdle();

#if defined(OS_LINUX) && defined(USE_X11)

// On bots, we might have a simple window manager which always activates new