remoting/test/test_chromoting_client_unittest.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/test/test_chromoting_client_unittest.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR gab #18 + fix build error Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ppapi/nacl_irt/irt_ppapi.cc ('K') | « remoting/test/protocol_perftest.cc ('k') | sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc » ('j') | services/navigation/content_client/browser_main_parts.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/test/test_chromoting_client_unittest.cc

diff --git a/remoting/test/test_chromoting_client_unittest.cc b/remoting/test/test_chromoting_client_unittest.cc

index 3cfc96172c77386192576b9bd6a7edc97eac5601..848a990a9b95979b3208ac2a9fde737b0cd98272 100644

--- a/remoting/test/test_chromoting_client_unittest.cc

+++ b/remoting/test/test_chromoting_client_unittest.cc

@@ -9,6 +9,7 @@

#include "base/macros.h"

#include "base/memory/ptr_util.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "remoting/protocol/fake_connection_to_host.h"

#include "remoting/signaling/fake_signal_strategy.h"

#include "remoting/test/connection_setup_info.h"

@@ -86,7 +87,7 @@ void TestChromotingClientTest::TearDown() {

// The IceTransportFactory destroys the PortAllocator via a DeleteSoon

// operation. If we do not allow the message loop to run here, we run the

// risk of the DeleteSoon task being dropped and incurring a memory leak.

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

}

void TestChromotingClientTest::ConnectionStateChanged(