Move GrContext::makeDrawContext to new GrContextPriv object

Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext. The "creating" makeDrawContext needs to be public for external image filters.

The 3 specialized drawContext creators on GrContextPriv (to wrap backend objects) are also to be kept from public use and will be used to remove SkSurface::MakeRenderTargetDirect.

Split out of: https://codereview.chromium.org/2176333002/ (Remove SkSurface::MakeRenderTargetDirect)

TBR=bsalomon@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002

Committed: https://skia.googlesource.com/skia/+/4fd74aec9f6c68c66483bcc6735793440b1ba184

[robertphillips, 2016-08-03 18:05:07]

Description was changed from

==========
Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext.
The "creating" makeDrawContext needs to be public for external image filters.
==========

to

==========
Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext.
The "creating" makeDrawContext needs to be public for external image filters.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002
==========

[robertphillips, 2016-08-03 18:06:40]

Description was changed from

==========
Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext.
The "creating" makeDrawContext needs to be public for external image filters.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002
==========

to

==========
Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext.
The "creating" makeDrawContext needs to be public for external image filters.

Split out of: https://codereview.chromium.org/2176333002/ (Remove
SkSurface::MakeRenderTargetDirect)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002
==========

[robertphillips, 2016-08-03 18:06:40]

robertphillips@google.com changed reviewers:
+ jvanverth@google.com

[robertphillips, 2016-08-03 18:08:57]

Description was changed from

==========
Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext.
The "creating" makeDrawContext needs to be public for external image filters.

Split out of: https://codereview.chromium.org/2176333002/ (Remove
SkSurface::MakeRenderTargetDirect)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002
==========

to

==========
Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext.
The "creating" makeDrawContext needs to be public for external image filters.

The 3 specialized drawContext creators on GrContextPriv (to wrap backend
objects) are also to be kept from public use.

Split out of: https://codereview.chromium.org/2176333002/ (Remove
SkSurface::MakeRenderTargetDirect)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002
==========

[robertphillips, 2016-08-03 18:12:55]

Description was changed from

==========
Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext.
The "creating" makeDrawContext needs to be public for external image filters.

The 3 specialized drawContext creators on GrContextPriv (to wrap backend
objects) are also to be kept from public use.

Split out of: https://codereview.chromium.org/2176333002/ (Remove
SkSurface::MakeRenderTargetDirect)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002
==========

to

==========
Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext.
The "creating" makeDrawContext needs to be public for external image filters.

The 3 specialized drawContext creators on GrContextPriv (to wrap backend
objects) are also to be kept from public use and will be used to remove
SkSurface::MakeRenderTargetDirect.

Split out of: https://codereview.chromium.org/2176333002/ (Remove
SkSurface::MakeRenderTargetDirect)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002
==========

[jvanverth1, 2016-08-03 20:32:34]

lgtm

[robertphillips, 2016-08-03 20:36:53]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 20:37:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:05:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:05:19]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-08-03 21:24:01]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-08-03 21:24:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-08-03 21:25:37]

Description was changed from

==========
Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext.
The "creating" makeDrawContext needs to be public for external image filters.

The 3 specialized drawContext creators on GrContextPriv (to wrap backend
objects) are also to be kept from public use and will be used to remove
SkSurface::MakeRenderTargetDirect.

Split out of: https://codereview.chromium.org/2176333002/ (Remove
SkSurface::MakeRenderTargetDirect)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002
==========

to

==========
Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext.
The "creating" makeDrawContext needs to be public for external image filters.

The 3 specialized drawContext creators on GrContextPriv (to wrap backend
objects) are also to be kept from public use and will be used to remove
SkSurface::MakeRenderTargetDirect.

Split out of: https://codereview.chromium.org/2176333002/ (Remove
SkSurface::MakeRenderTargetDirect)

TBR=bsalomon@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002
==========

[robertphillips, 2016-08-03 21:25:37]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[commit-bot: I haz the power, 2016-08-03 21:25:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:25:40]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[robertphillips, 2016-08-03 21:25:52]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-08-03 21:25:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:26:55]

Description was changed from

==========
Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext.
The "creating" makeDrawContext needs to be public for external image filters.

The 3 specialized drawContext creators on GrContextPriv (to wrap backend
objects) are also to be kept from public use and will be used to remove
SkSurface::MakeRenderTargetDirect.

Split out of: https://codereview.chromium.org/2176333002/ (Remove
SkSurface::MakeRenderTargetDirect)

TBR=bsalomon@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002
==========

to

==========
Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext.
The "creating" makeDrawContext needs to be public for external image filters.

The 3 specialized drawContext creators on GrContextPriv (to wrap backend
objects) are also to be kept from public use and will be used to remove
SkSurface::MakeRenderTargetDirect.

Split out of: https://codereview.chromium.org/2176333002/ (Remove
SkSurface::MakeRenderTargetDirect)

TBR=bsalomon@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002

Committed:
https://skia.googlesource.com/skia/+/4fd74aec9f6c68c66483bcc6735793440b1ba184
==========

[commit-bot: I haz the power, 2016-08-03 21:26:56]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4fd74aec9f6c68c66483bcc6735793440b1ba184