Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2621)

Unified Diff: ash/shell.cc

Issue 2211463002: mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO comments with bug for WmWindowMus ShelfItemDetails support. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shell.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shell.cc
diff --git a/ash/shell.cc b/ash/shell.cc
index ae6b8f2e5df54e96e9a477c763664c126e6b7489..e117dbda8d15cbe97fb5dbe216f70130e956c5a1 100644
--- a/ash/shell.cc
+++ b/ash/shell.cc
@@ -56,7 +56,6 @@
#include "ash/root_window_controller.h"
#include "ash/shelf/shelf.h"
#include "ash/shelf/shelf_widget.h"
-#include "ash/shelf/shelf_window_watcher.h"
#include "ash/shell_init_params.h"
#include "ash/utility/screenshot_controller.h"
#include "ash/wm/ash_focus_rules.h"
@@ -368,13 +367,6 @@ void Shell::CreateShelf() {
DCHECK_GT(session_state_delegate_->NumberOfLoggedInUsers(), 0);
wm_shell_->CreateShelfDelegate();
- // TODO(jamescook): This is here for historical reasons. Move it to WmShell.
- // http://crbug.com/629257
- if (!shelf_window_watcher_) {
- shelf_window_watcher_.reset(
- new ShelfWindowWatcher(wm_shell_->shelf_model()));
- }
-
RootWindowControllerList controllers = GetAllRootWindowControllers();
for (RootWindowControllerList::iterator iter = controllers.begin();
iter != controllers.end(); ++iter)
@@ -645,10 +637,6 @@ Shell::~Shell() {
wm_shell_->DeleteWindowCycleController();
wm_shell_->DeleteWindowSelectorController();
- // |shelf_window_watcher_| has a weak pointer to the shelf model and has
- // window observers.
- shelf_window_watcher_.reset();
-
// Destroy all child windows including widgets.
window_tree_host_manager_->CloseChildWindows();
// MruWindowTracker must be destroyed after all windows have been deleted to
« no previous file with comments | « ash/shell.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698