Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2211453004: Remove useless code to invalidate rects on the HostWindow. It's a no-op for frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 setScrollbarsSuppressed(true); 366 setScrollbarsSuppressed(true);
367 } 367 }
368 368
369 bool FrameView::didFirstLayout() const 369 bool FrameView::didFirstLayout() const
370 { 370 {
371 return !m_firstLayout; 371 return !m_firstLayout;
372 } 372 }
373 373
374 void FrameView::invalidateRect(const IntRect& rect) 374 void FrameView::invalidateRect(const IntRect& rect)
375 { 375 {
376 if (!parent()) {
377 if (HostWindow* window = getHostWindow())
378 window->invalidateRect(rect);
379 return;
380 }
381
382 LayoutPartItem layoutItem = m_frame->ownerLayoutItem(); 376 LayoutPartItem layoutItem = m_frame->ownerLayoutItem();
383 if (layoutItem.isNull()) 377 if (layoutItem.isNull())
384 return; 378 return;
385 379
386 IntRect paintInvalidationRect = rect; 380 IntRect paintInvalidationRect = rect;
387 paintInvalidationRect.move(layoutItem.borderLeft() + layoutItem.paddingLeft( ), 381 paintInvalidationRect.move(layoutItem.borderLeft() + layoutItem.paddingLeft( ),
388 layoutItem.borderTop() + layoutItem.paddingTop()); 382 layoutItem.borderTop() + layoutItem.paddingTop());
389 // FIXME: We should not allow paint invalidation out of paint invalidation s tate. crbug.com/457415 383 // FIXME: We should not allow paint invalidation out of paint invalidation s tate. crbug.com/457415
390 DisablePaintInvalidationStateAsserts paintInvalidationAssertDisabler; 384 DisablePaintInvalidationStateAsserts paintInvalidationAssertDisabler;
391 layoutItem.invalidatePaintRectangle(LayoutRect(paintInvalidationRect)); 385 layoutItem.invalidatePaintRectangle(LayoutRect(paintInvalidationRect));
(...skipping 3889 matching lines...) Expand 10 before | Expand all | Expand 10 after
4281 } 4275 }
4282 4276
4283 bool FrameView::canThrottleRendering() const 4277 bool FrameView::canThrottleRendering() const
4284 { 4278 {
4285 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled()) 4279 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled())
4286 return false; 4280 return false;
4287 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling); 4281 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling);
4288 } 4282 }
4289 4283
4290 } // namespace blink 4284 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698