Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2211433003: Obfuscation on for chromium code (Closed)

Created:
4 years, 4 months ago by smaier
Modified:
4 years, 4 months ago
Reviewers:
Yaron, Peter Wen, agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Obfuscation on for chromium code DO NOT SUBMIT This cl will not be submitted by me (since my end date is next week), however this is how we'd turn on obfuscation when we get a chance. Obfuscation saves us 660kb on our .dex size and 53kb memory/process. BUG=625704

Patch Set 1 #

Patch Set 2 : Renaming source files, repackaging classes #

Patch Set 3 : Added dependency on UsedByReflection CL #

Patch Set 4 : Tests seem to pass locally #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/android/java/proguard.flags View 1 2 chunks +10 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 2235923002 Patch 1

Messages

Total messages: 19 (19 generated)
smaier
The CQ bit was checked by smaier@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-03 20:10:16 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2211433003/1
4 years, 4 months ago (2016-08-03 20:10:40 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-03 22:41:26 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/115641)
4 years, 4 months ago (2016-08-03 22:41:27 UTC) #4
smaier
The CQ bit was checked by smaier@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-10 13:48:10 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2211433003/20001
4 years, 4 months ago (2016-08-10 13:48:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-10 14:59:38 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/119824)
4 years, 4 months ago (2016-08-10 14:59:39 UTC) #8
smaier
The CQ bit was checked by smaier@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-10 18:55:50 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2211433003/40001
4 years, 4 months ago (2016-08-10 18:56:17 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-10 21:03:01 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/120082)
4 years, 4 months ago (2016-08-10 21:03:02 UTC) #12
smaier
The CQ bit was checked by smaier@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-11 15:10:43 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2211433003/60001
4 years, 4 months ago (2016-08-11 15:11:00 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-11 15:48:11 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 4 months ago (2016-08-11 15:48:12 UTC) #16
smaier
Description was changed from ========== Obfuscation on for chromium code BUG=625704 ========== to ========== Obfuscation ...
4 years, 4 months ago (2016-08-11 15:51:54 UTC) #17
smaier
smaier@chromium.org changed reviewers: + agrieve@chromium.org, wnwen@chromium.org, yfriedman@chromium.org
4 years, 4 months ago (2016-08-11 15:51:54 UTC) #18
smaier
4 years, 4 months ago (2016-08-11 17:33:59 UTC) #19 
Description was changed from

==========
Obfuscation on for chromium code

DO NOT SUBMIT 

This cl will not be submitted by me (since my end date is next week),
however this is how we'd turn on obfuscation when we get a chance.

BUG=625704
==========

to

==========
Obfuscation on for chromium code

DO NOT SUBMIT 

This cl will not be submitted by me (since my end date is next week),
however this is how we'd turn on obfuscation when we get a chance.

Obfuscation saves us 660kb on our .dex size and 53kb memory/process.

BUG=625704
==========

Powered by Google App Engine
This is Rietveld 408576698