chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java - Issue 2211433002: Making Android Url bar behavior to ESCAPE key same as in Desktop Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java

Issue 2211433002: Making Android Url bar behavior to ESCAPE key same as in Desktop Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed redundant hideSuggestions() and hideKeyboard() calls. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java b/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java

index b1926e1f8aaad0b46a196b3f25ef8069124dcc96..ee9b823693be1a2c4bf99a9ad49f829b966cf635 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java

@@ -72,8 +72,9 @@ public class KeyboardShortcuts {

return true;

case KeyEvent.KEYCODE_ESCAPE:

if (event.getAction() == KeyEvent.ACTION_DOWN && event.getRepeatCount() == 0) {

- return activity.exitFullscreenIfShowing();

+ if (activity.exitFullscreenIfShowing()) return true;

}

+ break;

case KeyEvent.KEYCODE_TV:

case KeyEvent.KEYCODE_GUIDE:

case KeyEvent.KEYCODE_DVR:

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java » ('j') | no next file with comments »