Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2211403003: [MD settings] remove overscroll in subpages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changed to hidden Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_main/settings_main.html
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html
index 5b4e48964fc0de2c544364ae8ca68dc8f52295e3..ea6886ded40056228f387d6f15e947828d57dac5 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.html
+++ b/chrome/browser/resources/settings/settings_main/settings_main.html
@@ -65,7 +65,7 @@
<template is="dom-if"
if="[[showAdvancedSettings_(pageVisibility.advancedSettings)]]">
<template is="dom-if"
- if="[[showAdvancedToggle_(showPages_.basic, inSubpage_)]]">
+ if="[[showTopLevelPages_(showPages_.basic, inSubpage_)]]">
<div id="toggleSpacer"></div>
<div id="toggleContainer" hidden$="[[showNoResultsFound_]]">
<div id="advancedToggle" on-tap="toggleAdvancedPage_">
@@ -85,7 +85,9 @@
<settings-about-page current-route="{{currentRoute}}">
</settings-about-page>
</template>
- <div id="overscroll" style="padding-bottom: [[overscroll_]]px"></div>
+ <div id="overscroll" style="padding-bottom: [[overscroll_]]px"
+ hidden$="[[!showTopLevelPages_(showPages_.basic, inSubpage_)]]">
+ </div>
</template>
<script src="settings_main.js"></script>
<script src="/search_settings.js"></script>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698