Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Side by Side Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2211403003: [MD settings] remove overscroll in subpages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changed to hidden Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-main' displays the selected settings page. 7 * 'settings-main' displays the selected settings page.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-main', 10 is: 'settings-main',
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 arrowState_: function(opened) { 118 arrowState_: function(opened) {
119 return opened ? 'settings:arrow-drop-up' : 'cr:arrow-drop-down'; 119 return opened ? 'settings:arrow-drop-up' : 'cr:arrow-drop-down';
120 }, 120 },
121 121
122 /** 122 /**
123 * @param {boolean} showBasicPage 123 * @param {boolean} showBasicPage
124 * @param {boolean} inSubpage 124 * @param {boolean} inSubpage
125 * @return {boolean} 125 * @return {boolean}
126 * @private 126 * @private
127 */ 127 */
128 showAdvancedToggle_: function(showBasicPage, inSubpage) { 128 showTopLevelPages_: function(showBasicPage, inSubpage) {
129 return showBasicPage && !inSubpage; 129 return showBasicPage && !inSubpage;
130 }, 130 },
131 131
132 /** 132 /**
133 * @private 133 * @private
134 */ 134 */
135 currentRouteChanged_: function(newRoute) { 135 currentRouteChanged_: function(newRoute) {
136 this.inSubpage_ = newRoute.subpage.length > 0; 136 this.inSubpage_ = newRoute.subpage.length > 0;
137 this.style.height = this.inSubpage_ ? '100%' : ''; 137 this.style.height = this.inSubpage_ ? '100%' : '';
138 138
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 243
244 /** 244 /**
245 * @param {(boolean|undefined)} visibility 245 * @param {(boolean|undefined)} visibility
246 * @return {boolean} True unless visibility is false. 246 * @return {boolean} True unless visibility is false.
247 * @private 247 * @private
248 */ 248 */
249 showAdvancedSettings_: function(visibility) { 249 showAdvancedSettings_: function(visibility) {
250 return visibility !== false; 250 return visibility !== false;
251 }, 251 },
252 }); 252 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698