third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp - Issue 2211353003: Remove code to block sync XHRs during microtask executions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 2211353003: Remove code to block sync XHRs during microtask executions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/Deprecation.cpp ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

index 50a81331c4973b122a869acee3ed2fbfa6a239f0..ce557463698935e4f2983803df51abd588333de0 100644

--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

@@ -632,11 +632,7 @@ bool XMLHttpRequest::initSend(ExceptionState& exceptionState)

}

if (!m_async && exceptionState.isolate() && v8::MicrotasksScope::IsRunningMicrotasks(exceptionState.isolate())) {

- Deprecation::countDeprecation(getExecutionContext(), UseCounter::During_Microtask_SyncXHR);

- if (RuntimeEnabledFeatures::disableBlockingMethodsDuringMicrotasksEnabled()) {

- exceptionState.throwDOMException(InvalidAccessError, "Cannot send() synchronous requests during microtask execution.");

- return false;

- }

+ UseCounter::count(getExecutionContext(), UseCounter::During_Microtask_SyncXHR);

}