Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/action/ResolvedSearchAction.java

Issue 2211353002: [TTS] Gather surrounding text on Tap before any UX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unused code and consolidated two functions, updated comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/action/ResolvedSearchAction.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/action/ResolvedSearchAction.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/action/ResolvedSearchAction.java
new file mode 100644
index 0000000000000000000000000000000000000000..dc99a3ef7e8690f635f4ef181fe128d5da5004b1
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/action/ResolvedSearchAction.java
@@ -0,0 +1,52 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.contextualsearch.action;
+
+import org.chromium.chrome.browser.contextualsearch.gesture.SearchGestureHost;
+
+/**
+ * Represents a Search Action that will gather and examine surrounding text in order to
+ * "resolve" what to search for.
+ * Right now this class is just being used to extract surrounding context for a tap
+ * action before issuing the resolution request to determine if we want to suppress
+ * the tap. Longer term it will actually do the resolution request & search request.
+ * This is part of the 2016-refactoring (crbug.com/624609, go/cs-refactoring-2016).
+ */
+public class ResolvedSearchAction extends SearchAction {
+ // ============================================================================================
+ // Constructor
+ // ============================================================================================
+
+ /**
+ * Constructs a Search Action that extracts context for a Tap, using the given listener and
+ * host. Current implementation is limited to gathering the text surrounding a Tap gesture in
+ * order to determine whether a search should be done or not.
+ * @param listener The object to notify when the {@link SearchAction} state changes.
+ * @param host The host that provides environment data to the {@link SearchAction}.
+ */
+ public ResolvedSearchAction(SearchActionListener listener, SearchGestureHost host) {
+ super(listener, host);
+ }
+
+ // ============================================================================================
+ // Abstract implementations
+ // ============================================================================================
+
+ @Override
+ public void extractContext() {
+ requestSurroundingText();
+ }
+
+ // ============================================================================================
+ // State handling
+ // ============================================================================================
+
+ @Override
+ protected void onSurroundingTextReady() {
+ super.onSurroundingTextReady();
+
+ notifyContextReady();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698