Begins work on ARM64, first assembler test.

runtime/vm/cpu_arm64.cc

+// Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#include "vm/globals.h"
+
+#if defined(TARGET_ARCH_ARM64)
+
+#include "vm/cpu.h"
+#include "vm/cpuinfo.h"
+#include "vm/simulator.h"
+
+#if defined(HOST_ARCH_ARM64)
+#include <sys/syscall.h>  /* NOLINT */
+#include <unistd.h>  /* NOLINT */
+#endif
+
+namespace dart {
+
+void CPU::FlushICache(uword start, uword size) {
+#if defined(USING_SIMULATOR)
+  // Nothing to do.
+#else
+  UNIMPLEMENTED();
+#endif
+}
+
+
+const char* CPU::Id() {
+  return
+#if !defined(HOST_ARCH_ARM64)
+  "sim"

[regis, 2014/04/01 19:52:53]

Should this be "simarm64", as expected in cpu_test.cc? Why is it not failing,
btw?

[zra, 2014/04/01 20:35:08]

The "arm64" below is included unconditionally, making the full string "simarm64"
when HOST_ARCH_ARM64 is undefined. (This is just copied from cpu_arm.cc with 64
tacked on the end.)

[regis, 2014/04/01 22:25:15]

I see. Tricky. An #else would not kill us.

+#endif  // !defined(HOST_ARCH_ARM64)
+  "arm64";
+}
+
+
+const char* HostCPUFeatures::hardware_ = NULL;
+#if defined(DEBUG)
+bool HostCPUFeatures::initialized_ = false;
+#endif
+
+
+#if defined(HOST_ARCH_ARM64)
+void HostCPUFeatures::InitOnce() {
+  CpuInfo::InitOnce();
+  hardware_ = CpuInfo::GetCpuModel();
+#if defined(DEBUG)
+  initialized_ = true;
+#endif
+}
+
+
+void HostCPUFeatures::Cleanup() {
+  DEBUG_ASSERT(initialized_);
+#if defined(DEBUG)
+  initialized_ = false;
+#endif
+  ASSERT(hardware_ != NULL);
+  free(const_cast<char*>(hardware_));
+  hardware_ = NULL;
+  CpuInfo::Cleanup();
+}
+
+#else
+
+void HostCPUFeatures::InitOnce() {
+  CpuInfo::InitOnce();
+  hardware_ = CpuInfo::GetCpuModel();
+#if defined(DEBUG)
+  initialized_ = true;
+#endif
+}
+
+
+void HostCPUFeatures::Cleanup() {
+  DEBUG_ASSERT(initialized_);
+#if defined(DEBUG)
+  initialized_ = false;
+#endif
+  ASSERT(hardware_ != NULL);
+  free(const_cast<char*>(hardware_));
+  hardware_ = NULL;
+  CpuInfo::Cleanup();
+}
+#endif  // defined(HOST_ARCH_ARM64)
+
+}  // namespace dart
+
+#endif  // defined TARGET_ARCH_ARM64