MD Settings: Refactor RoutableBehavior into MainPageBehavior

MD Settings: Refactor RoutableBehavior into MainPageBehavior

This merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

This is a mechanical change only. Other than merging 2 behaviors into 1 and making a couple functions @private, there's no logical changes, and the behavior should be identical.

BUG=589681
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/21ec36c8b328a13cc23984d8adb33a49b96a20f9
Cr-Commit-Position: refs/heads/master@{#410433}

[michaelpg, 2016-08-06 03:11:04]

Description was changed from

==========
MD Settings: Refactor RoutableBehavior into MainPageBehavior

This merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

BUG=589681
==========

to

==========
MD Settings: Refactor RoutableBehavior into MainPageBehavior

This merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

BUG=589681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-06 03:20:09]

Description was changed from

==========
MD Settings: Refactor RoutableBehavior into MainPageBehavior

This merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

BUG=589681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Refactor RoutableBehavior into MainPageBehavior

This merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

This is a mechanical change only. Other than merging 2 behaviors into 1 and
making a couple functions @private, there's no logical changes, and the behavior
should be identical.

BUG=589681
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-06 03:20:36]

michaelpg@chromium.org changed reviewers:
+ dschuyler@chromium.org

[michaelpg, 2016-08-06 03:20:37]

Dave, care to take this one? Simplifies a few things and clears the way for my
next animations CL.

https://codereview.chromium.org/2211303004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/main_page_behavior.js
(right):

https://codereview.chromium.org/2211303004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:44:
currentRouteChanged: function(newRoute, oldRoute) {
Same code, just moved up to the other public functions and given a proper /**
annotation */.

https://codereview.chromium.org/2211303004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:163:
playExpandSection_: function(section) {
Exact same code, just moved up one.

https://codereview.chromium.org/2211303004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:278:
toggleOtherSectionsHidden_: function(sectionName, hidden) {
Again, exact same code from the top, just put down here with the private section
helper functions.

[dschuyler, 2016-08-08 18:13:03]

RS LGTM

[michaelpg, 2016-08-08 19:33:20]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-08-08 19:33:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2211303004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-08 19:33:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 20:25:31]

Description was changed from

==========
MD Settings: Refactor RoutableBehavior into MainPageBehavior

This merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

This is a mechanical change only. Other than merging 2 behaviors into 1 and
making a couple functions @private, there's no logical changes, and the behavior
should be identical.

BUG=589681
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Refactor RoutableBehavior into MainPageBehavior

This merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

This is a mechanical change only. Other than merging 2 behaviors into 1 and
making a couple functions @private, there's no logical changes, and the behavior
should be identical.

BUG=589681
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-08 20:25:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-08 20:28:50]

Description was changed from

==========
MD Settings: Refactor RoutableBehavior into MainPageBehavior

This merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

This is a mechanical change only. Other than merging 2 behaviors into 1 and
making a couple functions @private, there's no logical changes, and the behavior
should be identical.

BUG=589681
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Refactor RoutableBehavior into MainPageBehavior

This merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

This is a mechanical change only. Other than merging 2 behaviors into 1 and
making a couple functions @private, there's no logical changes, and the behavior
should be identical.

BUG=589681
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/21ec36c8b328a13cc23984d8adb33a49b96a20f9
Cr-Commit-Position: refs/heads/master@{#410433}
==========

[commit-bot: I haz the power, 2016-08-08 20:28:51]

Patchset 2 (id:??) landed as
https://crrev.com/21ec36c8b328a13cc23984d8adb33a49b96a20f9
Cr-Commit-Position: refs/heads/master@{#410433}