Reify type params on map literals

Reify type params on map literals

Fixes #621

R=jmesserly@google.com, leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/881a304f51a12869a5965cfaa55731d17cf73527

[vsm, 2016-08-05 00:23:43]

Description was changed from

==========
Reify type params on map literals

Fixes #621
==========

to

==========
Reify type params on map literals

Fixes #621
==========

[vsm, 2016-08-05 00:23:43]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[Leaf, 2016-08-05 00:31:19]

leafp@google.com changed reviewers:
+ leafp@google.com

[Leaf, 2016-08-05 00:31:20]

lgtm.  This may cause some breakage, we may want to do some pre-triaging.

[Jennifer Messerly, 2016-08-05 13:48:33]

lgtm

https://codereview.chromium.org/2211293002/diff/40001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2211293002/diff/40001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:4949: var reifyTypeArgs = typeArgs != null
&& typeArgs.any((t) => !t.isDynamic);
typeArguments should never be null on an InterfaceType, so you shouldn't need a
check for it here.

[vsm, 2016-08-05 14:15:03]

https://codereview.chromium.org/2211293002/diff/40001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2211293002/diff/40001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:4949: var reifyTypeArgs = typeArgs != null
&& typeArgs.any((t) => !t.isDynamic);
On 2016/08/05 13:48:32, John Messerly wrote:
> typeArguments should never be null on an InterfaceType, so you shouldn't need
a
> check for it here.

Removed - thanks!

[vsm, 2016-08-05 14:15:55]

On 2016/08/05 00:31:20, Leaf wrote:
> lgtm.  This may cause some breakage, we may want to do some pre-triaging.

I will test.  BTW, the lack of this is causing of our current runtime subtype
failure warnings.

[vsm, 2016-08-05 14:16:12]

Description was changed from

==========
Reify type params on map literals

Fixes #621
==========

to

==========
Reify type params on map literals

Fixes #621

R=jmesserly@google.com, leafp@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/881a304f51a12869a5965cfaa557...
==========

[vsm, 2016-08-05 14:16:14]

Committed patchset #4 (id:60001) manually as
881a304f51a12869a5965cfaa55731d17cf73527 (presubmit successful).