Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 2211283004: Drop test-only WebFrameClient params/functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
index 1f10cdce555b80a091fc1b41d1f63e677406e4ec..4bb43639ef4486609401047940c17b2cb40d8c77 100644
--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
@@ -384,43 +384,23 @@ void FrameLoaderClientImpl::detached(FrameDetachType type)
m_webFrame->setCoreFrame(nullptr);
}
-void FrameLoaderClientImpl::dispatchWillSendRequest(
- DocumentLoader* loader, unsigned long identifier, ResourceRequest& request,
- const ResourceResponse& redirectResponse)
+void FrameLoaderClientImpl::dispatchWillSendRequest(ResourceRequest& request)
{
// Give the WebFrameClient a crack at the request.
if (m_webFrame->client()) {
WrappedResourceRequest webreq(request);
- WrappedResourceResponse webresp(redirectResponse);
- m_webFrame->client()->willSendRequest(
- m_webFrame, identifier, webreq, webresp);
+ m_webFrame->client()->willSendRequest(m_webFrame, webreq);
}
}
-void FrameLoaderClientImpl::dispatchDidReceiveResponse(DocumentLoader* loader,
- unsigned long identifier,
- const ResourceResponse& response)
+void FrameLoaderClientImpl::dispatchDidReceiveResponse(const ResourceResponse& response)
{
if (m_webFrame->client()) {
WrappedResourceResponse webresp(response);
- m_webFrame->client()->didReceiveResponse(identifier, webresp);
+ m_webFrame->client()->didReceiveResponse(webresp);
}
}
-void FrameLoaderClientImpl::dispatchDidChangeResourcePriority(unsigned long identifier, ResourceLoadPriority priority, int intraPriorityValue)
-{
- if (m_webFrame->client())
- m_webFrame->client()->didChangeResourcePriority(identifier, static_cast<WebURLRequest::Priority>(priority), intraPriorityValue);
-}
-
-// Called when a particular resource load completes
-void FrameLoaderClientImpl::dispatchDidFinishLoading(DocumentLoader* loader,
- unsigned long identifier)
-{
- if (m_webFrame->client())
- m_webFrame->client()->didFinishResourceLoad(m_webFrame, identifier);
-}
-
void FrameLoaderClientImpl::dispatchDidFinishDocumentLoad()
{
// TODO(dglazkov): Sadly, workers are WebFrameClients, and they can totally

Powered by Google App Engine
This is Rietveld 408576698