third_party/WebKit/Source/core/loader/FrameLoaderClient.h - Issue 2211283004: Drop test-only WebFrameClient params/functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoaderClient.h

Issue 2211283004: Drop test-only WebFrameClient params/functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameLoaderClient.h

diff --git a/third_party/WebKit/Source/core/loader/FrameLoaderClient.h b/third_party/WebKit/Source/core/loader/FrameLoaderClient.h

index 65da964bc8d2568293971491c05be2be3aebb9b3..0dd606bf14cea94ec8ddb2e3e76f4e38a983fede 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoaderClient.h

+++ b/third_party/WebKit/Source/core/loader/FrameLoaderClient.h

@@ -90,9 +90,8 @@ public:

virtual bool hasWebView() const = 0; // mainly for assertions

- virtual void dispatchWillSendRequest(DocumentLoader*, unsigned long identifier, ResourceRequest&, const ResourceResponse& redirectResponse) = 0;

- virtual void dispatchDidReceiveResponse(DocumentLoader*, unsigned long identifier, const ResourceResponse&) = 0;

- virtual void dispatchDidFinishLoading(DocumentLoader*, unsigned long identifier) = 0;

+ virtual void dispatchWillSendRequest(ResourceRequest&) = 0;

+ virtual void dispatchDidReceiveResponse(const ResourceResponse&) = 0;

virtual void dispatchDidLoadResourceFromMemoryCache(const ResourceRequest&, const ResourceResponse&) = 0;

virtual void dispatchDidHandleOnloadEvents() = 0;

@@ -241,8 +240,6 @@ public:

// If an HTML document is being loaded, informs the embedder that the document will have its <body> attached soon.

virtual void dispatchWillInsertBody() { }

- virtual void dispatchDidChangeResourcePriority(unsigned long identifier, ResourceLoadPriority, int intraPriorityValue) { }

virtual std::unique_ptr<WebServiceWorkerProvider> createServiceWorkerProvider() = 0;

virtual bool isControlledByServiceWorker(DocumentLoader&) = 0;