Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Issue 2211283004: Drop test-only WebFrameClient params/functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
index b9dcc40ac5785f6f53ab42b578be7bab4e3deb51..1d8a489187bf24ba71847999558509e59898b068 100644
--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
@@ -315,15 +315,14 @@ inline DocumentLoader* FrameFetchContext::masterDocumentLoader() const
void FrameFetchContext::dispatchDidChangeResourcePriority(unsigned long identifier, ResourceLoadPriority loadPriority, int intraPriorityValue)
{
- frame()->loader().client()->dispatchDidChangeResourcePriority(identifier, loadPriority, intraPriorityValue);
TRACE_EVENT_INSTANT1("devtools.timeline", "ResourceChangePriority", TRACE_EVENT_SCOPE_THREAD, "data", InspectorChangeResourcePriorityEvent::data(identifier, loadPriority));
InspectorInstrumentation::didChangeResourcePriority(frame(), identifier, loadPriority);
}
-void FrameFetchContext::prepareRequest(unsigned long identifier, ResourceRequest& request, const ResourceResponse& redirectResponse)
+void FrameFetchContext::prepareRequest(ResourceRequest& request)
{
frame()->loader().applyUserAgent(request);
- frame()->loader().client()->dispatchWillSendRequest(m_documentLoader, identifier, request, redirectResponse);
+ frame()->loader().client()->dispatchWillSendRequest(request);
}
void FrameFetchContext::dispatchWillSendRequest(unsigned long identifier, ResourceRequest& request, const ResourceResponse& redirectResponse, const FetchInitiatorInfo& initiatorInfo)
@@ -332,7 +331,7 @@ void FrameFetchContext::dispatchWillSendRequest(unsigned long identifier, Resour
// willStartLoadingResource(), before revalidation policy is determined.
// That call doesn't exist for redirects, so call preareRequest() here.
if (!redirectResponse.isNull())
- prepareRequest(identifier, request, redirectResponse);
+ prepareRequest(request);
TRACE_EVENT_INSTANT1("devtools.timeline", "ResourceSendRequest", TRACE_EVENT_SCOPE_THREAD, "data", InspectorSendRequestEvent::data(identifier, frame(), request));
InspectorInstrumentation::willSendRequest(frame(), identifier, masterDocumentLoader(), request, redirectResponse, initiatorInfo);
if (frame()->frameScheduler())
@@ -361,8 +360,6 @@ void FrameFetchContext::dispatchDidDownloadData(unsigned long identifier, int da
void FrameFetchContext::dispatchDidFinishLoading(unsigned long identifier, double finishTime, int64_t encodedDataLength)
{
frame()->loader().progress().completeProgress(identifier);
- frame()->loader().client()->dispatchDidFinishLoading(m_documentLoader, identifier);
-
TRACE_EVENT_INSTANT1("devtools.timeline", "ResourceFinish", TRACE_EVENT_SCOPE_THREAD, "data", InspectorResourceFinishEvent::data(identifier, finishTime, false));
InspectorInstrumentation::didFinishLoading(frame(), identifier, finishTime, encodedDataLength);
if (frame()->frameScheduler())
@@ -372,7 +369,6 @@ void FrameFetchContext::dispatchDidFinishLoading(unsigned long identifier, doubl
void FrameFetchContext::dispatchDidFail(unsigned long identifier, const ResourceError& error, bool isInternalRequest)
{
frame()->loader().progress().completeProgress(identifier);
- frame()->loader().client()->dispatchDidFinishLoading(m_documentLoader, identifier);
TRACE_EVENT_INSTANT1("devtools.timeline", "ResourceFinish", TRACE_EVENT_SCOPE_THREAD, "data", InspectorResourceFinishEvent::data(identifier, 0, true));
InspectorInstrumentation::didFailLoading(frame(), identifier, error);
// Notification to FrameConsole should come AFTER InspectorInstrumentation call, DevTools front-end relies on this.
@@ -422,7 +418,7 @@ void FrameFetchContext::willStartLoadingResource(unsigned long identifier, Resou
{
TRACE_EVENT_ASYNC_BEGIN1("blink.net", "Resource", identifier, "data", loadResourceTraceData(identifier, request.url(), request.priority()));
frame()->loader().progress().willStartLoading(identifier);
- prepareRequest(identifier, request, ResourceResponse());
+ prepareRequest(request);
if (!m_documentLoader || m_documentLoader->fetcher()->archive() || !request.url().isValid())
return;
@@ -826,7 +822,7 @@ void FrameFetchContext::dispatchDidReceiveResponseInternal(unsigned long identif
MixedContentChecker::handleCertificateError(frame(), response, frameType, requestContext);
frame()->loader().progress().incrementProgress(identifier, response);
- frame()->loader().client()->dispatchDidReceiveResponse(m_documentLoader, identifier, response);
+ frame()->loader().client()->dispatchDidReceiveResponse(response);
TRACE_EVENT_INSTANT1("devtools.timeline", "ResourceReceiveResponse", TRACE_EVENT_SCOPE_THREAD, "data", InspectorReceiveResponseEvent::data(identifier, frame(), response));
DocumentLoader* documentLoader = masterDocumentLoader();
InspectorInstrumentation::didReceiveResourceResponse(frame(), identifier, documentLoader, response, resource);
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameFetchContext.h ('k') | third_party/WebKit/Source/core/loader/FrameLoaderClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698