Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1757)

Unified Diff: components/test_runner/web_frame_test_proxy.h

Issue 2211283004: Drop test-only WebFrameClient params/functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/web_frame_test_client.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_frame_test_proxy.h
diff --git a/components/test_runner/web_frame_test_proxy.h b/components/test_runner/web_frame_test_proxy.h
index f072f9ac6b55b18ebdf2f35a56894794ad316ea4..15f3f01c05c0e1ea7e3e2f59049d2518b776ab07 100644
--- a/components/test_runner/web_frame_test_proxy.h
+++ b/components/test_runner/web_frame_test_proxy.h
@@ -231,36 +231,15 @@ class WebFrameTestProxy : public Base, public WebFrameTestProxyBase {
Base::didDispatchPingLoader(url);
}
- void willSendRequest(
- blink::WebLocalFrame* frame,
- unsigned identifier,
- blink::WebURLRequest& request,
- const blink::WebURLResponse& redirect_response) override {
- Base::willSendRequest(frame, identifier, request, redirect_response);
- test_client()->willSendRequest(frame, identifier, request,
- redirect_response);
- }
-
- void didReceiveResponse(unsigned identifier,
- const blink::WebURLResponse& response) override {
- test_client()->didReceiveResponse(identifier, response);
- Base::didReceiveResponse(identifier, response);
- }
-
- void didChangeResourcePriority(unsigned identifier,
- const blink::WebURLRequest::Priority& priority,
- int intra_priority_value) override {
- // This is not implemented in RenderFrameImpl, so need to explicitly call
- // into the base proxy.
- test_client()->didChangeResourcePriority(identifier, priority,
- intra_priority_value);
- Base::didChangeResourcePriority(
- identifier, priority, intra_priority_value);
+ void willSendRequest(blink::WebLocalFrame* frame,
+ blink::WebURLRequest& request) override {
+ Base::willSendRequest(frame, request);
+ test_client()->willSendRequest(frame, request);
}
- void didFinishResourceLoad(blink::WebLocalFrame* frame,
- unsigned identifier) override {
- test_client()->didFinishResourceLoad(frame, identifier);
+ void didReceiveResponse(const blink::WebURLResponse& response) override {
+ test_client()->didReceiveResponse(response);
+ Base::didReceiveResponse(response);
}
blink::WebNavigationPolicy decidePolicyForNavigation(
« no previous file with comments | « components/test_runner/web_frame_test_client.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698