Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: components/plugins/renderer/webview_plugin.cc

Issue 2211283004: Drop test-only WebFrameClient params/functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/plugins/renderer/webview_plugin.h ('k') | components/test_runner/layout_test_runtime_flags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/plugins/renderer/webview_plugin.cc
diff --git a/components/plugins/renderer/webview_plugin.cc b/components/plugins/renderer/webview_plugin.cc
index 7992f78bc5eca6fc5724d0cddc8f52d50094dfc8..81a26f43427684f980d4cb681c1315919cbe63f9 100644
--- a/components/plugins/renderer/webview_plugin.cc
+++ b/components/plugins/renderer/webview_plugin.cc
@@ -95,8 +95,9 @@ WebViewPlugin::~WebViewPlugin() {
}
void WebViewPlugin::ReplayReceivedData(WebPlugin* plugin) {
- if (!response_.isNull()) {
- plugin->didReceiveResponse(response_);
+ const WebURLResponse& response = web_frame_->dataSource()->response();
+ if (!response.isNull()) {
+ plugin->didReceiveResponse(response);
size_t total_bytes = 0;
for (std::list<std::string>::iterator it = data_.begin(); it != data_.end();
++it) {
@@ -256,11 +257,6 @@ blink::WebInputEventResult WebViewPlugin::handleInputEvent(
return handled;
}
-void WebViewPlugin::didReceiveResponse(const WebURLResponse& response) {
- DCHECK(response_.isNull());
- response_ = response;
-}
-
void WebViewPlugin::didReceiveData(const char* data, int data_length) {
data_.push_back(std::string(data, data_length));
}
@@ -337,11 +333,6 @@ void WebViewPlugin::didClearWindowObject(WebLocalFrame* frame) {
delegate_->GetV8Handle(isolate));
}
-void WebViewPlugin::didReceiveResponse(unsigned identifier,
- const WebURLResponse& response) {
- WebFrameClient::didReceiveResponse(identifier, response);
-}
-
void WebViewPlugin::OnDestruct() {}
void WebViewPlugin::OnZoomLevelChanged() {
« no previous file with comments | « components/plugins/renderer/webview_plugin.h ('k') | components/test_runner/layout_test_runtime_flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698