Drop test-only WebFrameClient params/functions

Drop test-only WebFrameClient params/functions

* WebFrameClient::didFinishLoading() is only used for
tests that dumpResourceLoadCallbacks(), and only one test
(http/tests/cache/cancel-multiple-post-xhrs.html) is
explicitly testing whether or not the load finishes.
Rewrite that tests to listen to XHR onabort instead.

* WebFrameClient::didChangeResourcePriority() is only used
for the 3 tests that dumpResourceRequestPriorities().
Rewrite those tests as WebFrameTests (for
http/tests/loading/script-priorities.html and
http/tests/loading/promote-img-in-viewport-priority.html)
or ResourceFetcherTests (http/tests/loading/sync-xhr-priority.html),
and remove both the flag and the callback.

* WebFrameClient::didReceiveResponse() has two
parameters, one of which, |identifier|, is only used for
looking up the original request url for that response.
Dump the response url instead, which will only be
different for requests that redirect.

* Similarly, WebFrameClient::willSendRequest() has two
parameters that are only used for layout tests, |identifier|
and |redirectResponse|. |identifier| is unnecessary due
to the changes to didReceiveResponse(). |redirectResponse|
is used to dump redirect information, which is only
relevant for 2 tests (http/tests/loading/307-after-303-after-post.html
and http/tests/loading/redirect-methods.html). Not dumping the redirect
response information leads to a small loss of information,
because it does not put the redirect source and redirect
destination urls right next to each other. However, neither
layout test interleaves redirecting requests, so it ends
up being very clear which requests are related, and all
tests that dumpResourceLoadCallbacks() also dumpFrameLoadCallbacks(),
which ensures that a redirect willSendRequest() dump is
immediately followed by a didReceiveServerRedirectForProvisionalLoadForFrame
dump.

BUG=

Committed: https://crrev.com/8489f1bf78c2c6f296e0df6c529751d29e8a0188
Cr-Commit-Position: refs/heads/master@{#413907}

[Nate Chapin, 2016-08-05 23:50:19]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 23:50:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 00:44:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 00:44:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nate Chapin, 2016-08-08 20:31:50]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 20:32:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 21:37:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 21:37:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nate Chapin, 2016-08-08 21:46:36]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 21:46:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 00:33:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 00:33:25]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-08-10 23:26:17]

Description was changed from

==========
Drop test-only WebFrameClient params/functions

BUG=
==========

to

==========
Drop test-only WebFrameClient params/functions

* WebFrameClient::didFinishLoading() is only used for
tests that dumpResourceLoadCallbacks(), and only one test
(http/tests/cache/cancel-multiple-post-xhrs.html) is
explicitly testing whether or not the load finishes.
Rewrite that tests to listen to XHR onabort instead.

* WebFrameClient::didChangeResourcePriority() is only used
for the 3 tests that dumpResourceRequestPriorities().
Rewrite those tests as WebFrameTests (for
http/tests/loading/script-priorities.html and
http/tests/loading/promote-img-in-viewport-priority.html)
or ResourceFetcherTests (http/tests/loading/sync-xhr-priority.html),
and remove both the flag and the callback.

* 


BUG=
==========

[Nate Chapin, 2016-08-10 23:34:42]

Description was changed from

==========
Drop test-only WebFrameClient params/functions

* WebFrameClient::didFinishLoading() is only used for
tests that dumpResourceLoadCallbacks(), and only one test
(http/tests/cache/cancel-multiple-post-xhrs.html) is
explicitly testing whether or not the load finishes.
Rewrite that tests to listen to XHR onabort instead.

* WebFrameClient::didChangeResourcePriority() is only used
for the 3 tests that dumpResourceRequestPriorities().
Rewrite those tests as WebFrameTests (for
http/tests/loading/script-priorities.html and
http/tests/loading/promote-img-in-viewport-priority.html)
or ResourceFetcherTests (http/tests/loading/sync-xhr-priority.html),
and remove both the flag and the callback.

* 


BUG=
==========

to

==========
Drop test-only WebFrameClient params/functions

* WebFrameClient::didFinishLoading() is only used for
tests that dumpResourceLoadCallbacks(), and only one test
(http/tests/cache/cancel-multiple-post-xhrs.html) is
explicitly testing whether or not the load finishes.
Rewrite that tests to listen to XHR onabort instead.

* WebFrameClient::didChangeResourcePriority() is only used
for the 3 tests that dumpResourceRequestPriorities().
Rewrite those tests as WebFrameTests (for
http/tests/loading/script-priorities.html and
http/tests/loading/promote-img-in-viewport-priority.html)
or ResourceFetcherTests (http/tests/loading/sync-xhr-priority.html),
and remove both the flag and the callback.

* WebFrameClient::didReceiveResponse() has two
parameters, one of which, |identifier|, is only used for
looking up the original request url for that response.
Dump the response url instead, which will only be
different for requests that redirect.

* Similarly, WebFrameClient::willSendRequest() has two
parameters that are only used for layout tests, |identifier|
and |redirectResponse|. |identifier| is unnecessary due
to the changes to didReceiveResponse(). |redirectResponse|
is used to dump redirect information, which is only
relevant for 2 tests (http/tests/loading/307-after-303-after-post.html
and http/tests/loading/redirect-methods.html). Not dumping the redirect
response information leads to a small loss of information,
because it does not put the redirect source and redirect
destination urls right next to each other. However, neither
layout test interleaves redirecting requests, so it ends
up being very clear which requests are related, and all
tests that dumpResourceLoadCallbacks() also dumpFrameLoadCallbacks(),
which ensures that a redirect willSendRequest() dump is
immediately followed by a didReceiveServerRedirectForProvisionalLoadForFrame
dump.


BUG=
==========

[Nate Chapin, 2016-08-10 23:42:12]

japhet@chromium.org changed reviewers:
+ dpranke@chromium.org

[Nate Chapin, 2016-08-10 23:42:14]

Sorry for the size of this patch. :/

If you agree with the patch description, everything should be very mechanical,
except the WebViewPlugin changes and the layout->unit test translations in
WebFrameTest and ResourceFetcherTest.

https://codereview.chromium.org/2211283004/diff/40001/components/plugins/rend...
File components/plugins/renderer/webview_plugin.h (left):

https://codereview.chromium.org/2211283004/diff/40001/components/plugins/rend...
components/plugins/renderer/webview_plugin.h:140: // This method is defined in
WebPlugin as well as in WebFrameClient, but with
WebPlugin::didReceiveResponse and WebFrameClient::didReceiveResponse now have
the same parameters, causing inheritance confusion. However, the response
WebViewPlugin wants (the one provided in a WebPluginClient::didReceiveResponse
callback) is guaranteed to be the committed DocumentLoader/WebDataSource's
response. Use that directly in WebViewPlugin::ReplayReceivedData instead of
listening to the didReceiveResponse callback.

https://codereview.chromium.org/2211283004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt
(left):

https://codereview.chromium.org/2211283004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:1:
http://127.0.0.1:8000/misc/resources/redirect-to-http-url.php - willSendRequest
<NSURLRequest URL http://127.0.0.1:8000/misc/resources/redirect-to-http-url.php,
main document URL
http://127.0.0.1:8000/misc/will-send-request-returns-null-on-redirect.html, http
method GET> redirectResponse (null)
This expected result apparently wasn't deleted when the associated test was.

[Dirk Pranke, 2016-08-11 00:48:40]

Seems reasonable.

LGTM.

[Nate Chapin, 2016-08-11 03:07:05]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2016-08-11 03:07:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 03:11:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 03:11:13]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nate Chapin, 2016-08-18 18:01:34]

japhet@chromium.org changed reviewers:
+ avi@chromium.org, bauerb@chromium.org

[Nate Chapin, 2016-08-18 18:01:35]

bauerb: Please review the changes in components/plugins/

avi: Please review the (very mechanical) changes in content/renderer/

[Nate Chapin, 2016-08-18 18:06:20]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 18:06:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 18:55:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 18:55:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bernhard Bauer, 2016-08-18 19:00:10]

plugins LGTM

[Nate Chapin, 2016-08-18 22:09:50]

japhet@chromium.org changed reviewers:
+ sievers@chromium.org
- avi@chromium.org

[Nate Chapin, 2016-08-18 22:09:51]

Oops, avi is OOO. sievers, would you be up for a quick review of these
mechanical content/renderer/ changes?

[no sievers, 2016-08-22 23:08:03]

On 2016/08/18 22:09:51, Nate Chapin wrote:
> Oops, avi is OOO. sievers, would you be up for a quick review of these
> mechanical content/renderer/ changes?

lgtm

[Nate Chapin, 2016-08-22 23:08:27]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2016-08-22 23:08:28]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2211283004/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-22 23:08:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 23:13:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 23:13:15]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nate Chapin, 2016-08-22 23:34:20]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2016-08-22 23:34:21]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
dpranke@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2211283004/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-22 23:35:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 00:34:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 00:34:34]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Nate Chapin, 2016-08-23 19:40:24]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2016-08-23 19:40:25]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
dpranke@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2211283004/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-23 19:41:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 23:20:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 23:20:22]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nate Chapin, 2016-08-23 23:21:04]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2016-08-23 23:21:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 00:28:35]

Description was changed from

==========
Drop test-only WebFrameClient params/functions

* WebFrameClient::didFinishLoading() is only used for
tests that dumpResourceLoadCallbacks(), and only one test
(http/tests/cache/cancel-multiple-post-xhrs.html) is
explicitly testing whether or not the load finishes.
Rewrite that tests to listen to XHR onabort instead.

* WebFrameClient::didChangeResourcePriority() is only used
for the 3 tests that dumpResourceRequestPriorities().
Rewrite those tests as WebFrameTests (for
http/tests/loading/script-priorities.html and
http/tests/loading/promote-img-in-viewport-priority.html)
or ResourceFetcherTests (http/tests/loading/sync-xhr-priority.html),
and remove both the flag and the callback.

* WebFrameClient::didReceiveResponse() has two
parameters, one of which, |identifier|, is only used for
looking up the original request url for that response.
Dump the response url instead, which will only be
different for requests that redirect.

* Similarly, WebFrameClient::willSendRequest() has two
parameters that are only used for layout tests, |identifier|
and |redirectResponse|. |identifier| is unnecessary due
to the changes to didReceiveResponse(). |redirectResponse|
is used to dump redirect information, which is only
relevant for 2 tests (http/tests/loading/307-after-303-after-post.html
and http/tests/loading/redirect-methods.html). Not dumping the redirect
response information leads to a small loss of information,
because it does not put the redirect source and redirect
destination urls right next to each other. However, neither
layout test interleaves redirecting requests, so it ends
up being very clear which requests are related, and all
tests that dumpResourceLoadCallbacks() also dumpFrameLoadCallbacks(),
which ensures that a redirect willSendRequest() dump is
immediately followed by a didReceiveServerRedirectForProvisionalLoadForFrame
dump.


BUG=
==========

to

==========
Drop test-only WebFrameClient params/functions

* WebFrameClient::didFinishLoading() is only used for
tests that dumpResourceLoadCallbacks(), and only one test
(http/tests/cache/cancel-multiple-post-xhrs.html) is
explicitly testing whether or not the load finishes.
Rewrite that tests to listen to XHR onabort instead.

* WebFrameClient::didChangeResourcePriority() is only used
for the 3 tests that dumpResourceRequestPriorities().
Rewrite those tests as WebFrameTests (for
http/tests/loading/script-priorities.html and
http/tests/loading/promote-img-in-viewport-priority.html)
or ResourceFetcherTests (http/tests/loading/sync-xhr-priority.html),
and remove both the flag and the callback.

* WebFrameClient::didReceiveResponse() has two
parameters, one of which, |identifier|, is only used for
looking up the original request url for that response.
Dump the response url instead, which will only be
different for requests that redirect.

* Similarly, WebFrameClient::willSendRequest() has two
parameters that are only used for layout tests, |identifier|
and |redirectResponse|. |identifier| is unnecessary due
to the changes to didReceiveResponse(). |redirectResponse|
is used to dump redirect information, which is only
relevant for 2 tests (http/tests/loading/307-after-303-after-post.html
and http/tests/loading/redirect-methods.html). Not dumping the redirect
response information leads to a small loss of information,
because it does not put the redirect source and redirect
destination urls right next to each other. However, neither
layout test interleaves redirecting requests, so it ends
up being very clear which requests are related, and all
tests that dumpResourceLoadCallbacks() also dumpFrameLoadCallbacks(),
which ensures that a redirect willSendRequest() dump is
immediately followed by a didReceiveServerRedirectForProvisionalLoadForFrame
dump.


BUG=
==========

[commit-bot: I haz the power, 2016-08-24 00:28:37]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-24 00:30:30]

Description was changed from

==========
Drop test-only WebFrameClient params/functions

* WebFrameClient::didFinishLoading() is only used for
tests that dumpResourceLoadCallbacks(), and only one test
(http/tests/cache/cancel-multiple-post-xhrs.html) is
explicitly testing whether or not the load finishes.
Rewrite that tests to listen to XHR onabort instead.

* WebFrameClient::didChangeResourcePriority() is only used
for the 3 tests that dumpResourceRequestPriorities().
Rewrite those tests as WebFrameTests (for
http/tests/loading/script-priorities.html and
http/tests/loading/promote-img-in-viewport-priority.html)
or ResourceFetcherTests (http/tests/loading/sync-xhr-priority.html),
and remove both the flag and the callback.

* WebFrameClient::didReceiveResponse() has two
parameters, one of which, |identifier|, is only used for
looking up the original request url for that response.
Dump the response url instead, which will only be
different for requests that redirect.

* Similarly, WebFrameClient::willSendRequest() has two
parameters that are only used for layout tests, |identifier|
and |redirectResponse|. |identifier| is unnecessary due
to the changes to didReceiveResponse(). |redirectResponse|
is used to dump redirect information, which is only
relevant for 2 tests (http/tests/loading/307-after-303-after-post.html
and http/tests/loading/redirect-methods.html). Not dumping the redirect
response information leads to a small loss of information,
because it does not put the redirect source and redirect
destination urls right next to each other. However, neither
layout test interleaves redirecting requests, so it ends
up being very clear which requests are related, and all
tests that dumpResourceLoadCallbacks() also dumpFrameLoadCallbacks(),
which ensures that a redirect willSendRequest() dump is
immediately followed by a didReceiveServerRedirectForProvisionalLoadForFrame
dump.


BUG=
==========

to

==========
Drop test-only WebFrameClient params/functions

* WebFrameClient::didFinishLoading() is only used for
tests that dumpResourceLoadCallbacks(), and only one test
(http/tests/cache/cancel-multiple-post-xhrs.html) is
explicitly testing whether or not the load finishes.
Rewrite that tests to listen to XHR onabort instead.

* WebFrameClient::didChangeResourcePriority() is only used
for the 3 tests that dumpResourceRequestPriorities().
Rewrite those tests as WebFrameTests (for
http/tests/loading/script-priorities.html and
http/tests/loading/promote-img-in-viewport-priority.html)
or ResourceFetcherTests (http/tests/loading/sync-xhr-priority.html),
and remove both the flag and the callback.

* WebFrameClient::didReceiveResponse() has two
parameters, one of which, |identifier|, is only used for
looking up the original request url for that response.
Dump the response url instead, which will only be
different for requests that redirect.

* Similarly, WebFrameClient::willSendRequest() has two
parameters that are only used for layout tests, |identifier|
and |redirectResponse|. |identifier| is unnecessary due
to the changes to didReceiveResponse(). |redirectResponse|
is used to dump redirect information, which is only
relevant for 2 tests (http/tests/loading/307-after-303-after-post.html
and http/tests/loading/redirect-methods.html). Not dumping the redirect
response information leads to a small loss of information,
because it does not put the redirect source and redirect
destination urls right next to each other. However, neither
layout test interleaves redirecting requests, so it ends
up being very clear which requests are related, and all
tests that dumpResourceLoadCallbacks() also dumpFrameLoadCallbacks(),
which ensures that a redirect willSendRequest() dump is
immediately followed by a didReceiveServerRedirectForProvisionalLoadForFrame
dump.

BUG=

Committed: https://crrev.com/8489f1bf78c2c6f296e0df6c529751d29e8a0188
Cr-Commit-Position: refs/heads/master@{#413907}
==========

[commit-bot: I haz the power, 2016-08-24 00:30:32]

Patchset 6 (id:??) landed as
https://crrev.com/8489f1bf78c2c6f296e0df6c529751d29e8a0188
Cr-Commit-Position: refs/heads/master@{#413907}