Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2211253002: mus/views: Create a mus OSExchangeData::Provider stub, and use it. (Closed)

Created:
4 years, 4 months ago by Elliot Glaysher
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus/views: Create a mus OSExchangeData::Provider stub, and use it. This prevents a crash in the current views code when running under mus. The OS native OSExchangeData::Provider is used, and on X11, this crashes because the views using application does not have an X11 connection. BUG=614037 Committed: https://crrev.com/7466e8d81c770b6fdab97ba06a6918bf787f9e3a Cr-Commit-Position: refs/heads/master@{#410205}

Patch Set 1 #

Patch Set 2 : Maybe fix windows. #

Patch Set 3 : Maybe fix windows #

Patch Set 4 : Fix windows: The fixening #

Patch Set 5 : Fix DCHECK. Fixed unit tests? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -1 line) Patch
M ui/base/dragdrop/os_exchange_data_provider_factory.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/views/mus/os_exchange_data_provider_mus.h View 1 2 1 chunk +88 lines, -0 lines 0 comments Download
A ui/views/mus/os_exchange_data_provider_mus.cc View 1 2 3 1 chunk +147 lines, -0 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 1 3 chunks +6 lines, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 5 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
Elliot Glaysher
I was hoping that I wouldn't have to commit this stub first, but it turns ...
4 years, 4 months ago (2016-08-05 22:14:17 UTC) #19
sky
LGTM
4 years, 4 months ago (2016-08-05 22:51:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2211253002/80001
4 years, 4 months ago (2016-08-05 23:00:36 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-05 23:06:18 UTC) #24
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 23:08:17 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7466e8d81c770b6fdab97ba06a6918bf787f9e3a
Cr-Commit-Position: refs/heads/master@{#410205}

Powered by Google App Engine
This is Rietveld 408576698