Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Unified Diff: chrome/browser/extensions/renderer_initialization_browsertest.cc

Issue 2211213002: Revert of [Extensions] Ensure ordering of extension [un]loaded, activated messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/renderer_initialization_browsertest.cc
diff --git a/chrome/browser/extensions/renderer_initialization_browsertest.cc b/chrome/browser/extensions/renderer_initialization_browsertest.cc
deleted file mode 100644
index 466443536b9ca17933fb96d0d35527a6c9852e11..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/renderer_initialization_browsertest.cc
+++ /dev/null
@@ -1,40 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/extensions/extension_browsertest.h"
-#include "chrome/browser/extensions/extension_service.h"
-#include "chrome/browser/ui/tabs/tab_strip_model.h"
-#include "chrome/test/base/ui_test_utils.h"
-#include "content/public/test/browser_test_utils.h"
-
-namespace extensions {
-
-// Test that opening a window with an extension recorded as active, then
-// unloading the extension, all before the renderer is fully initialized,
-// doesn't crash. This addresses crbug.com/528026, where messages could be sent
-// out of order if an extension unloaded before the activation message was sent.
-IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest,
- TestRendererStartupWithConflictingMessages) {
- // Load up an extension an begin opening an URL to a page within it. Since
- // this will be an extension tab, the extension will be active within that
- // process.
- const Extension* extension =
- LoadExtension(test_data_dir_.AppendASCII("simple_with_file"));
- ASSERT_TRUE(extension);
- GURL url = extension->GetResourceURL("file.html");
- browser()->OpenURL(content::OpenURLParams(url, content::Referrer(),
- NEW_FOREGROUND_TAB,
- ui::PAGE_TRANSITION_TYPED, false));
- // Without waiting for the tab to finish, unload the extension.
- extension_service()->UnloadExtension(extension->id(),
- UnloadedExtensionInfo::REASON_TERMINATE);
- content::WebContents* web_contents =
- browser()->tab_strip_model()->GetActiveWebContents();
- // Wait for the web contents to stop loading.
- content::WaitForLoadStop(web_contents);
- EXPECT_EQ(url, web_contents->GetLastCommittedURL());
- ASSERT_FALSE(web_contents->IsCrashed());
-}
-
-} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698