Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2211203002: Cancel ServiceManager connection requests if source Instance dies (Closed)

Created:
4 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cancel ServiceManager connection requests if source Instance dies Prevents orphaned services from unintentionally triggering a restart of the service instance which created them. This resolves flaky behavior wherein a renderer attempts to connect to the browser after its BrowserContext service was shut down. BUG=634392 R=ben@chromium.org Committed: https://crrev.com/3403dd79ccf777ef4b9c92ea11bd39b61af83bcb Cr-Commit-Position: refs/heads/master@{#409904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M services/shell/service_manager.h View 2 chunks +8 lines, -1 line 0 comments Download
M services/shell/service_manager.cc View 7 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Ken Rockot(use gerrit already)
4 years, 4 months ago (2016-08-04 20:25:05 UTC) #2
Ben Goodger (Google)
lgtm
4 years, 4 months ago (2016-08-04 20:26:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2211203002/1
4 years, 4 months ago (2016-08-04 20:26:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 21:27:46 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 21:29:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3403dd79ccf777ef4b9c92ea11bd39b61af83bcb
Cr-Commit-Position: refs/heads/master@{#409904}

Powered by Google App Engine
This is Rietveld 408576698