fix #26962, invoking a known lambda is not a dynamic invoke

fix #26962, invoking a known lambda is not a dynamic invoke

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/5d8b2b5eac73d3d020c689fe0b8c0a888b780837

[Jennifer Messerly, 2016-08-04 15:17:17]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Jennifer Messerly, 2016-08-04 15:17:28]

Description was changed from

==========
fix #26962, invoking a known lambda is not a dynamic invoke

BUG=
==========

to

==========
fix #26962, invoking a known lambda is not a dynamic invoke
==========

[Jennifer Messerly, 2016-08-04 15:57:41]

https://codereview.chromium.org/2211053002/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/checker.dart (right):

https://codereview.chromium.org/2211053002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:24: bool
isKnownFunction(Expression expression, {bool instanceMethods: false}) {
Of funny, I wondered what was up with this different treatment of tear-offs. I
think it's covered by this bug you filed, that I just discovered:
https://github.com/dart-lang/sdk/issues/26393

so I may either fix it here or do a follow up, what do you think? It will change
some DOWN_CAST_COMPOSITES to errors in our test cases, so that was why I kept
the logic.

[Leaf, 2016-08-04 16:22:01]

lgtm.  Changing the instanceMethods logic either here or in a followup seems
reasonable, but I'd like to see some examples of the changes in the errors to
understand why - in general I would expect that changing an expressions type
from Bot -> _ to Top -> _ should produce strictly fewer errors, since Top -> _
<: Bot -> _, but I'm guessing there's an interaction with our casting logic?

https://codereview.chromium.org/2211053002/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/checker.dart (right):

https://codereview.chromium.org/2211053002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:24: bool
isKnownFunction(Expression expression, {bool instanceMethods: false}) {
On 2016/08/04 15:57:40, John Messerly wrote:
> Of funny, I wondered what was up with this different treatment of tear-offs. I
> think it's covered by this bug you filed, that I just discovered:
> https://github.com/dart-lang/sdk/issues/26393
> 
> so I may either fix it here or do a follow up, what do you think? It will
change
> some DOWN_CAST_COMPOSITES to errors in our test cases, so that was why I kept
> the logic.

Do you have an example of something that is changed by this?  I assume it has to
do with our treatment of "stupid casts" that are guaranteed to fail?

https://codereview.chromium.org/2211053002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:945: // according to our current
criteria.
This comment seems out of place.  Probably a remnant of one of the sorting
disasters.  Mind deleting it?

[Jennifer Messerly, 2016-08-04 18:27:37]

Thanks!

https://codereview.chromium.org/2211053002/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/checker.dart (right):

https://codereview.chromium.org/2211053002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:24: bool
isKnownFunction(Expression expression, {bool instanceMethods: false}) {
On 2016/08/04 16:22:01, Leaf wrote:
> On 2016/08/04 15:57:40, John Messerly wrote:
> > Of funny, I wondered what was up with this different treatment of tear-offs.
I
> > think it's covered by this bug you filed, that I just discovered:
> > https://github.com/dart-lang/sdk/issues/26393
> > 
> > so I may either fix it here or do a follow up, what do you think? It will
> change
> > some DOWN_CAST_COMPOSITES to errors in our test cases, so that was why I
kept
> > the logic.
> 
> Do you have an example of something that is changed by this?  I assume it has
to
> do with our treatment of "stupid casts" that are guaranteed to fail?

yeah, that was my thought, it might make more sense to see it in context. I'll
roll it into its own CL.

https://codereview.chromium.org/2211053002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:945: // according to our current
criteria.
On 2016/08/04 16:22:01, Leaf wrote:
> This comment seems out of place.  Probably a remnant of one of the sorting
> disasters.  Mind deleting it?

Done.

[Jennifer Messerly, 2016-08-04 18:30:29]

Description was changed from

==========
fix #26962, invoking a known lambda is not a dynamic invoke
==========

to

==========
fix #26962, invoking a known lambda is not a dynamic invoke

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5d8b2b5eac73d3d020c689fe0b8c0a888b780837
==========

[Jennifer Messerly, 2016-08-04 18:30:30]

Committed patchset #2 (id:20001) manually as
5d8b2b5eac73d3d020c689fe0b8c0a888b780837 (presubmit successful).