Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2210993002:
Stick with old yellow bookmark folder icons on Windows, even in MD. (Closed)
|
Created:
4 years, 4 months ago by Evan Stade Modified:
4 years, 4 months ago Reviewers:
Peter Kasting CC:
chromium-reviews, tfarina, noyau+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionStick with old yellow bookmark folder icons on Windows, even in MD.
BUG=633013
Committed: https://crrev.com/055a5526ac6933493707b6c9698d739ab56fb7b1
Cr-Commit-Position: refs/heads/master@{#410171}
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : unused fn #Messages
Total messages: 25 (16 generated)
The CQ bit was checked by estade@chromium.org to run a CQ dry run
estade@chromium.org changed reviewers: + pkasting@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
LGTM
The CQ bit was checked by estade@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pkasting@chromium.org Link to the patchset: https://codereview.chromium.org/2210993002/#ps20001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
estade@chromium.org changed reviewers: + sky@chromium.org
+sky for owners
The CQ bit was checked by estade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
estade@chromium.org changed reviewers: - sky@chromium.org
-sky, pkasting is an owner after all
The CQ bit was unchecked by estade@chromium.org
The CQ bit was checked by estade@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pkasting@chromium.org Link to the patchset: https://codereview.chromium.org/2210993002/#ps40001 (title: "unused fn")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Stick with old yellow bookmark folder icons on Windows, even in MD. BUG=633013 ========== to ========== Stick with old yellow bookmark folder icons on Windows, even in MD. BUG=633013 Committed: https://crrev.com/055a5526ac6933493707b6c9698d739ab56fb7b1 Cr-Commit-Position: refs/heads/master@{#410171} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/055a5526ac6933493707b6c9698d739ab56fb7b1 Cr-Commit-Position: refs/heads/master@{#410171} |
