Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10548)

Unified Diff: chrome/test/data/webui/settings/basic_page_browsertest.js

Issue 2210933004: Settings Router Refactor: Kill settings-router. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/basic_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/basic_page_browsertest.js b/chrome/test/data/webui/settings/basic_page_browsertest.js
index 4a9c9fe458830e76d09f0314aa411e8b445a0e21..78715fc465f309c06c09701edf816997b4be48ef 100644
--- a/chrome/test/data/webui/settings/basic_page_browsertest.js
+++ b/chrome/test/data/webui/settings/basic_page_browsertest.js
@@ -56,16 +56,12 @@ TEST_F('SettingsBasicPageBrowserTest', 'MAYBE_Load', function() {
// failing to find its host element.
test('scroll to section', function() {
// Setting the page and section will cause a scrollToSection_.
- self.getPage('basic').currentRoute = {
- page: 'basic',
- section: 'onStartup',
- subpage: [],
- };
+ settings.navigateTo(settings.Route.ON_STARTUP);
return new Promise(function(resolve, reject) {
var intervalId = window.setInterval(function() {
var page = self.getPage('basic');
- if (self.getSection(page, page.currentRoute.section)) {
+ if (self.getSection(page, settings.getCurrentRoute().section)) {
window.clearInterval(intervalId);
resolve();
}

Powered by Google App Engine
This is Rietveld 408576698