Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3675)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 2210933004: Settings Router Refactor: Kill settings-router. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/settings_page/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index e59f66455fb2b71168d6b7fbd8a5ab7ce5d38cfc..494228bfc6e777dd828c4b265df02f957c7dcdbf 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -14,15 +14,6 @@ Polymer({
advancedOpened_: Boolean,
/**
- * The current active route.
- * @type {!settings.Route}
- */
- currentRoute: {
- type: Object,
- notify: true,
- },
-
- /**
* Dictionary defining page visibility.
* @type {!GuestModePageVisibility}
*/
@@ -48,7 +39,7 @@ Polymer({
}.bind(this));
this.fire('toggle-advanced-page',
- settings.Route.ADVANCED.contains(this.currentRoute));
+ settings.Route.ADVANCED.contains(settings.getCurrentRoute()));
},
/**
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/settings_page/compiled_resources2.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698