Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2175)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 2210933004: Settings Router Refactor: Kill settings-router. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page/settings_router.js
diff --git a/chrome/browser/resources/settings/settings_page/settings_router.js b/chrome/browser/resources/settings/settings_page/settings_router.js
deleted file mode 100644
index bdde44f1ec1b49738467086d1851a2407468aa31..0000000000000000000000000000000000000000
--- a/chrome/browser/resources/settings/settings_page/settings_router.js
+++ /dev/null
@@ -1,37 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-/**
- * @fileoverview
- * 'settings-router' is only used to propagate route changes to bound elements.
- * All the real routing is defined within route.js.
- * TODO(tommycli): Remove once all elements migrated to RouteObserverBehavior.
- *
- * Example:
- * <settings-router current-route="{{currentRoute}}">
- * </settings-router>
- */
-Polymer({
- is: 'settings-router',
-
- behaviors: [settings.RouteObserverBehavior],
-
- properties: {
- /**
- * Only used to propagate settings.currentRoute to all the elements bound to
- * settings-router.
- * @type {!settings.Route}
- */
- currentRoute: {
- notify: true,
- type: Object,
- value: function() { return settings.getCurrentRoute(); },
- },
- },
-
- /** @protected */
- currentRouteChanged: function() {
- this.currentRoute = settings.getCurrentRoute();
- },
-});

Powered by Google App Engine
This is Rietveld 408576698