chrome/browser/resources/settings/settings_page/settings_section.js - Issue 2210933004: Settings Router Refactor: Kill settings-router.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_section.js

Issue 2210933004: Settings Router Refactor: Kill settings-router. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge yet again because this conflicts with everything Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/settings_page/settings_animated_pages.js ('K') | « chrome/browser/resources/settings/settings_page/settings_router.js ('k') | chrome/browser/resources/settings/settings_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_section.js

diff --git a/chrome/browser/resources/settings/settings_page/settings_section.js b/chrome/browser/resources/settings/settings_page/settings_section.js

index 1149e2ea81b7aa0fd017246548977f7e8916be2b..771bf4b7f5443d97ba032fb8ffc050d064295c4d 100644

--- a/chrome/browser/resources/settings/settings_page/settings_section.js

+++ b/chrome/browser/resources/settings/settings_page/settings_section.js

@@ -18,15 +18,10 @@ Polymer({

properties: {

/**

- * The current active route.

- */

- currentRoute: Object,

- /**

* The section is expanded to a full-page view when this property matches

* currentRoute.section.

- * The section name must match the name specified in settings_router.js.

+ * The section name must match the name specified in route.js.

section: {

type: String,