Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2210933004: Settings Router Refactor: Kill settings-router. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge yet again because this conflicts with everything Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/people_page.html
diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html
index 64989d344c4b63a5a37435d91cb032bbd5625860..4c4e8710d6068301e46c34c61a20c6f84facd991 100644
--- a/chrome/browser/resources/settings/people_page/people_page.html
+++ b/chrome/browser/resources/settings/people_page/people_page.html
@@ -72,8 +72,7 @@
margin: 16px 0 2px;
}
</style>
- <settings-animated-pages id="pages" current-route="{{currentRoute}}"
- section="people">
+ <settings-animated-pages id="pages" section="people">
<neon-animatable id="main">
<div class="settings-box first two-line">
<img id="profile-icon" src="[[profileIconUrl_]]"
@@ -237,7 +236,7 @@
</neon-animatable>
<template is="dom-if" name="sync">
<settings-subpage page-title="$i18n{syncPageTitle}">
- <settings-sync-page current-route="[[currentRoute]]">
+ <settings-sync-page>
Dan Beam 2016/08/05 18:25:18 nit: unwrap
tommycli 2016/08/05 18:54:05 Done.
</settings-sync-page>
</settings-subpage>
</template>
@@ -245,26 +244,20 @@
<template is="dom-if" name="quick-unlock-authenticate">
<settings-subpage page-title="$i18n{quickUnlockTitle}">
<settings-quick-unlock-authenticate
- set-modes="{{quickUnlockSetModes}}"
- current-route="{{currentRoute}}"
- profile-name="[[profileName_]]">
+ set-modes="{{quickUnlockSetModes}}" profile-name="[[profileName_]]">
Dan Beam 2016/08/05 18:25:18 nit: indent off
tommycli 2016/08/05 18:54:05 Done.
</settings-quick-unlock-authenticate>
</settings-subpage>
</template>
<template is="dom-if" name="quick-unlock-choose-method">
<settings-subpage page-title="$i18n{quickUnlockTitle}">
<settings-quick-unlock-choose-method
- set-modes="[[quickUnlockSetModes]]"
- current-route="{{currentRoute}}"
- prefs="{{prefs}}">
+ set-modes="[[quickUnlockSetModes]]" prefs="{{prefs}}">
</settings-quick-unlock-choose-method>
</settings-subpage>
</template>
<template is="dom-if" name="quick-unlock-setup-pin">
<settings-subpage page-title="$i18n{quickUnlockTitle}">
- <settings-quick-unlock-setup-pin
- set-modes="[[quickUnlockSetModes]]"
- current-route="{{currentRoute}}">
+ <settings-quick-unlock-setup-pin set-modes="[[quickUnlockSetModes]]">
</settings-quick-unlock-setup-pin>
</settings-subpage>
</template>

Powered by Google App Engine
This is Rietveld 408576698