Settings Router Refactor: Kill settings-router.

chrome/browser/resources/settings/privacy_page/privacy_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-privacy-page' is the settings page containing privacy and
  * security settings.
  */
 Polymer({
   is: 'settings-privacy-page',
 
+  behaviors: [settings.RouteObserverBehavior],
+
   properties: {
     /**
      * Preferences state.
      */
     prefs: {
       type: Object,
       notify: true,
     },
 
-    /**
-     * The current active route.
-     */
-    currentRoute: {
-      type: Object,
-      notify: true,
-    },
-
     /** @private */
-    showClearBrowsingDataDialog_: {
-      computed: 'computeShowClearBrowsingDataDialog_(currentRoute)',
-      type: Boolean,
-    },
+    showClearBrowsingDataDialog_: Boolean,
 
     /**
      * Dictionary defining page visibility.
      * @type {!PrivacyPageVisibility}
      */
     pageVisibility: Object,
   },
 
   ready: function() {
     this.ContentSettingsTypes = settings.ContentSettingsTypes;
   },
 
-  /**
-   * @return {boolean} Whether the Clear Browsing Data dialog should be showing.
-   * @private
-   */
-  computeShowClearBrowsingDataDialog_: function() {
-    var route = this.currentRoute;
-    return route && route.dialog == 'clear-browsing-data';
+  /** @protected */
+  currentRouteChanged: function() {

[Dan Beam, 2016/08/05 18:25:19]

can this be called at a time where |route| would be falsy?

[tommycli, 2016/08/05 18:54:06]

Done. |route| is actually never falsy now. It's defined as BASIC and then set
from the URL:
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/route....

+    var route = settings.getCurrentRoute();
+    this.showClearBrowsingDataDialog_ =
+        route && route.dialog == 'clear-browsing-data';
   },
 
   /** @private */
   onManageCertificatesTap_: function() {
 <if expr="use_nss_certs">
     settings.navigateTo(settings.Route.CERTIFICATES);
 </if>
 <if expr="is_win or is_macosx">
     settings.PrivacyPageBrowserProxyImpl.getInstance().
         showManageSSLCertificates();
 </if>
   },
 
   /** @private */
   onSiteSettingsTap_: function() {
     settings.navigateTo(settings.Route.SITE_SETTINGS);
   },
 
   /** @private */
   onClearBrowsingDataTap_: function() {
     settings.navigateTo(settings.Route.CLEAR_BROWSER_DATA);
   },
 
   /** @private */
   onDialogClosed_: function() {
     settings.navigateTo(settings.Route.PRIVACY);
   },
 });