Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: Source/devtools/front_end/TimelinePanel.js

Issue 221093002: Timeline: fix frame event dividers in Timeline's main view (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 views.mainViews = [this._tracingView()]; 301 views.mainViews = [this._tracingView()];
302 break; 302 break;
303 default: 303 default:
304 console.assert(false, "Unknown mode: " + mode); 304 console.assert(false, "Unknown mode: " + mode);
305 } 305 }
306 for (var i = 0; i < views.mainViews.length; ++i) 306 for (var i = 0; i < views.mainViews.length; ++i)
307 views.mainViews[i].addEventListener(WebInspector.SplitView.Event s.SidebarSizeChanged, this._sidebarResized, this); 307 views.mainViews[i].addEventListener(WebInspector.SplitView.Event s.SidebarSizeChanged, this._sidebarResized, this);
308 this._viewsMap[mode] = views; 308 this._viewsMap[mode] = views;
309 } 309 }
310 310
311 this._timelineView().setFrameModel(mode === WebInspector.TimelinePanel.M ode.Frames ? this._frameModel() : null);
312 return views; 311 return views;
313 }, 312 },
314 313
315 _createPresentationSelector: function() 314 _createPresentationSelector: function()
316 { 315 {
317 this._viewsMap = {}; 316 this._viewsMap = {};
318 317
319 var topPaneSidebarElement = this._topPane.sidebarElement(); 318 var topPaneSidebarElement = this._topPane.sidebarElement();
320 topPaneSidebarElement.id = "timeline-overview-sidebar"; 319 topPaneSidebarElement.id = "timeline-overview-sidebar";
321 320
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
566 this.element.classList.add("timeline-" + mode.toLowerCase() + "-view"); 565 this.element.classList.add("timeline-" + mode.toLowerCase() + "-view");
567 this._stackView.detachChildViews(); 566 this._stackView.detachChildViews();
568 var views = this._viewsForMode(mode); 567 var views = this._viewsForMode(mode);
569 this._currentViews = views.mainViews; 568 this._currentViews = views.mainViews;
570 for (var i = 0; i < this._currentViews.length; ++i) { 569 for (var i = 0; i < this._currentViews.length; ++i) {
571 var view = this._currentViews[i]; 570 var view = this._currentViews[i];
572 view.setWindowTimes(this.windowStartTime(), this.windowEndTime()); 571 view.setWindowTimes(this.windowStartTime(), this.windowEndTime());
573 this._stackView.appendView(view, "timelinePanelTimelineStackSplitVie wState"); 572 this._stackView.appendView(view, "timelinePanelTimelineStackSplitVie wState");
574 view.refreshRecords(this._textFilter._regex); 573 view.refreshRecords(this._textFilter._regex);
575 } 574 }
575 this._timelineView().setFrameModel(mode === WebInspector.TimelinePanel.M ode.Frames ? this._frameModel() : null);
576 this._overviewControl = views.overviewView; 576 this._overviewControl = views.overviewView;
577 this._overviewPane.setOverviewControl(this._overviewControl); 577 this._overviewPane.setOverviewControl(this._overviewControl);
578 this._updateSelectionDetails(); 578 this._updateSelectionDetails();
579 }, 579 },
580 580
581 /** 581 /**
582 * @param {boolean} userInitiated 582 * @param {boolean} userInitiated
583 */ 583 */
584 _startRecording: function(userInitiated) 584 _startRecording: function(userInitiated)
585 { 585 {
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
1185 * @param {!WebInspector.TimelineModel.Record} record 1185 * @param {!WebInspector.TimelineModel.Record} record
1186 * @return {boolean} 1186 * @return {boolean}
1187 */ 1187 */
1188 accept: function(record) 1188 accept: function(record)
1189 { 1189 {
1190 return !this._hiddenRecords[record.type]; 1190 return !this._hiddenRecords[record.type];
1191 }, 1191 },
1192 1192
1193 __proto__: WebInspector.TimelineModel.Filter.prototype 1193 __proto__: WebInspector.TimelineModel.Filter.prototype
1194 } 1194 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698