Simplify conditional call of PaintIndirect()

Simplify conditional call of PaintIndirect()

In http://crbug.com/628574 we determined that PaintIndirect() was still
used in modern Chrome. This CL corrects the source comments describing
when it is used, and removes conditionals that weren't triggered in
any of the reproductions of that bug.

BUG=622692
R=pkasting@chromium.org

Committed: https://crrev.com/10958c0a2ffe2828af635329b68c5522aa7cf75b
Cr-Commit-Position: refs/heads/master@{#412298}

[tomhudson, 2016-08-15 13:14:02]

Hi Peter! I'd like to try landing this (or a similar patch) with updated
comments and simplified conditionals; I verified locally that this still works
in the previous error cases.

[Peter Kasting, 2016-08-15 22:29:41]

LGTM

https://codereview.chromium.org/2210923003/diff/1/ui/native_theme/native_them...
File ui/native_theme/native_theme_win.cc (right):

https://codereview.chromium.org/2210923003/diff/1/ui/native_theme/native_them...
ui/native_theme/native_theme_win.cc:266: if
(!skia::SupportsPlatformPaint(canvas))
Nit: Reverse conditional and arms (so "else" clause isn't mentally a
double-negative)

[tomhudson, 2016-08-16 17:47:16]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-08-16 17:47:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2210923003/#ps20001
(title: "Nits")

[commit-bot: I haz the power, 2016-08-16 17:47:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 18:39:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-16 18:43:03]

Description was changed from

==========
Simplify conditional call of PaintIndirect()

In http://crbug.com/628574 we determined that PaintIndirect() was still
used in modern Chrome. This CL corrects the source comments describing
when it is used, and removes conditionals that weren't triggered in
any of the reproductions of that bug.

BUG=622692
R=pkasting@chromium.org
==========

to

==========
Simplify conditional call of PaintIndirect()

In http://crbug.com/628574 we determined that PaintIndirect() was still
used in modern Chrome. This CL corrects the source comments describing
when it is used, and removes conditionals that weren't triggered in
any of the reproductions of that bug.

BUG=622692
R=pkasting@chromium.org

Committed: https://crrev.com/10958c0a2ffe2828af635329b68c5522aa7cf75b
Cr-Commit-Position: refs/heads/master@{#412298}
==========

[commit-bot: I haz the power, 2016-08-16 18:43:04]

Patchset 2 (id:??) landed as
https://crrev.com/10958c0a2ffe2828af635329b68c5522aa7cf75b
Cr-Commit-Position: refs/heads/master@{#412298}