Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2210883002: [turbofan] Add support for "ignore OOB stores" to typed arrays. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for "ignore OOB stores" to typed arrays. Add missing support for the STORE_NO_TRANSITION_IGNORE_OUT_OF_BOUNDS store mode to TurboFan. R=epertoso@chromium.org BUG=v8:4470 Committed: https://crrev.com/fad8340199d28dc9e1bbe90f7f6b7d2fd8cdd812 Cr-Commit-Position: refs/heads/master@{#38329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -20 lines) Patch
M src/compiler/js-native-context-specialization.h View 1 chunk +4 lines, -6 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 7 chunks +58 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-04 07:55:42 UTC) #1
epertoso
lgtm
4 years, 4 months ago (2016-08-04 08:01:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210883002/1
4 years, 4 months ago (2016-08-04 08:26:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 08:28:21 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 08:30:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fad8340199d28dc9e1bbe90f7f6b7d2fd8cdd812
Cr-Commit-Position: refs/heads/master@{#38329}

Powered by Google App Engine
This is Rietveld 408576698