content/public/browser/bluetooth_chooser.h - Issue 2210873003: bluetooth: Allow updates on chooser items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/bluetooth_chooser.h

Issue 2210873003: bluetooth: Allow updates on chooser items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-fix-advertised-services

Patch Set: Change interface Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/bluetooth/bluetooth_device_chooser_controller.cc ('k') | content/shell/browser/layout_test/layout_test_bluetooth_chooser_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/bluetooth_chooser.h

diff --git a/content/public/browser/bluetooth_chooser.h b/content/public/browser/bluetooth_chooser.h

index aec3c2f19415c7606f2c6fe578d36aca43334318..6ad23c79fb5fbfae690ab5caec28fc69bfd6487f 100644

--- a/content/public/browser/bluetooth_chooser.h

+++ b/content/public/browser/bluetooth_chooser.h

@@ -68,9 +68,14 @@ class CONTENT_EXPORT BluetoothChooser {

enum class DiscoveryState { FAILED_TO_START, DISCOVERING, IDLE };

virtual void ShowDiscoveryState(DiscoveryState state) {}

- // Shows a new device in the chooser.

- virtual void AddDevice(const std::string& device_id,

- const base::string16& device_name) {}

+ // Adds a new device to the chooser or updates the information of an existing

+ // device.

+ virtual void AddOrUpdateDevice(const std::string& device_id,

+ bool should_update_name,

+ const base::string16& device_name,

+ bool is_gatt_connected,

+ bool is_paired,

+ int8_t* rssi) {}

juncai 2016/08/09 19:14:44 Some questions: 1. Does AddOrUpdateDevice() need t

ortuno 2016/08/09 19:23:17 Added comment to clarify why we pass in a pointer

// Tells the chooser that a device is no longer available. The chooser should

// not call DeviceSelected() for a device that's been removed.