Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2210863002: Revert of Remove hasGrammarMarker from internals (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove hasGrammarMarker from internals (patchset #1 id:1 of https://codereview.chromium.org/2191803002/ ) Reason for revert: Blink may still draw grammar markers when "Ask Google for suggestion" is checked, so testing of grammar markers should not be removed. BUG=633641 TBR=yosin@chromium.org, tkent@chromium.org Original issue's description: > Remove hasGrammarMarker from internals > > BUG=619452 > TEST=n/a; no behavior change > > Committed: https://crrev.com/bce93917093ec0d1acd2de4c769ffd18c7e3c075 > Cr-Commit-Position: refs/heads/master@{#408541} TBR=yosin@chromium.org,tkent@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=619452 Committed: https://crrev.com/c5a0304640b77b4fdddcccf35bc26cca7ed87ace Cr-Commit-Position: refs/heads/master@{#409740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Xiaocheng
Created Revert of Remove hasGrammarMarker from internals
4 years, 4 months ago (2016-08-04 07:11:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210863002/1
4 years, 4 months ago (2016-08-04 07:12:14 UTC) #3
tkent
lgtm
4 years, 4 months ago (2016-08-04 07:16:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 08:24:47 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 08:27:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5a0304640b77b4fdddcccf35bc26cca7ed87ace
Cr-Commit-Position: refs/heads/master@{#409740}

Powered by Google App Engine
This is Rietveld 408576698