Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 221083002: Fix assert failure caused by ImageExtractor and optimize test (Closed)

Created:
6 years, 8 months ago by oetuaho-nv
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix assert failure caused by ImageExtractor and optimize test unlockPixels is always called in the ImageExtractor destructor if m_skiaImage is non-null. Clear m_skiaImage if extractImage fails and lockPixels is never called so that lockPixels and unlockPixels calls will be in balance. Also optimize webgl-large-texture.html test, since some of the test timeouts could be caused by the test running too long. Optimizations include avoiding conversion between RGBA and RGB, checking the pixels in 32 bit chunks instead of 8 bits at a time, and loading the image from a file instead of generating a JPEG data URL dynamically. TEST=fast/canvas/webgl/webgl-large-texture.html BUG=358313 R=kbr@chromium.org, skyostil@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -26 lines) Patch
A + LayoutTests/fast/canvas/webgl/resources/white3900x3900.jpg View Binary file 0 comments Download
M LayoutTests/fast/canvas/webgl/webgl-large-texture.html View 3 chunks +31 lines, -24 lines 0 comments Download
M Source/platform/graphics/gpu/WebGLImageConversion.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sami
lgtm, thanks!
6 years, 8 months ago (2014-04-01 15:25:04 UTC) #1
Ken Russell (switch to Gerrit)
LGTM too; thanks for the fix.
6 years, 8 months ago (2014-04-01 18:43:38 UTC) #2
oetuaho-nv
The CQ bit was checked by oetuaho@nvidia.com
6 years, 8 months ago (2014-04-02 07:35:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/221083002/1
6 years, 8 months ago (2014-04-02 07:35:48 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 08:40:24 UTC) #5
Message was sent while issue was closed.
Change committed as 170642

Powered by Google App Engine
This is Rietveld 408576698