Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2210813002: Update component build documentation. (Closed)

Created:
4 years, 4 months ago by brettw
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update component build documentation. This build was recently made the default, and more documentation was added. This brings everything in sync. Committed: https://crrev.com/9fb64176b7586ea3a1afd56d145f37342b39f166 Cr-Commit-Position: refs/heads/master@{#409863}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +3 lines, -0 lines 2 comments Download
M docs/component_build.md View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
brettw
4 years, 4 months ago (2016-08-04 04:37:20 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/2210813002/diff/1/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/2210813002/diff/1/build/config/BUILDCONFIG.gn#newcode149 build/config/BUILDCONFIG.gn:149: # https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md I'm tempted to say that this ...
4 years, 4 months ago (2016-08-04 15:59:04 UTC) #7
brettw
https://codereview.chromium.org/2210813002/diff/1/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/2210813002/diff/1/build/config/BUILDCONFIG.gn#newcode149 build/config/BUILDCONFIG.gn:149: # https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md On 2016/08/04 15:59:04, Dirk Pranke wrote: > ...
4 years, 4 months ago (2016-08-04 18:26:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210813002/1
4 years, 4 months ago (2016-08-04 18:28:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 19:22:39 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 19:24:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fb64176b7586ea3a1afd56d145f37342b39f166
Cr-Commit-Position: refs/heads/master@{#409863}

Powered by Google App Engine
This is Rietveld 408576698