Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2210773002: Subzero: Use Cfg::getOptLevel() instead of ClFlags version. (Closed)

Created:
4 years, 4 months ago by Jim Stichnoth
Modified:
4 years, 4 months ago
Reviewers:
Eric Holk, Karl, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Use Cfg::getOptLevel() instead of ClFlags version. The opt level (O2 versus Om1) should be tested using Cfg::getOptLevel() instead of getFlags().getOptLevel() whenever possible. This is because if you run "-Om1 -force-O2=foo", and you're compiling foo, the first form tells you O2 while the second form tells you Om1. BUG= none R=eholk@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=386b52ed4f409b3ce54eb945d3ba3c7d80e13c11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/IceTargetLowering.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringARM32.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 4 months ago (2016-08-04 02:06:44 UTC) #3
Eric Holk
lgtm
4 years, 4 months ago (2016-08-05 17:03:50 UTC) #4
Jim Stichnoth
4 years, 4 months ago (2016-08-05 22:18:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
386b52ed4f409b3ce54eb945d3ba3c7d80e13c11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698