Add helper functions for throwing arity-related TypeErrors

Add helper functions for throwing arity-related TypeErrors

Add a few new helper functions that the generated bindings code can use
to throw TypeErrors for arity mismatches.
This reduces the binary footprint for these exceptional code-paths.
(Approx. 75kB smaller content_shell binary on Linux, x86-64, gcc-4.8.2)

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170666

[Mike West, 2014-04-02 06:33:05]

LGTM, this looks like a pretty reasonable way of moving repeated work out of the
generated bindings.

[Nils Barth (inactive), 2014-04-02 06:47:37]

Style tip, otherwise LGTM.

https://codereview.chromium.org/221073003/diff/1/Source/bindings/templates/me...
File Source/bindings/templates/methods.cpp (right):

https://codereview.chromium.org/221073003/diff/1/Source/bindings/templates/me...
Source/bindings/templates/methods.cpp:12: {{throw_arity_type_error(method,
method.number_of_required_arguments) | indent(8)}}
The 'indent' is not necessary, as this is one line.
Also, since it's one line, could you move the ';' out of the macro
and into this line, to make it clear that it's a one-liner?

Now documented at:
https://sites.google.com/a/chromium.org/dev/developers/jinja#TOC-Style

https://codereview.chromium.org/221073003/diff/1/Source/bindings/templates/me...
Source/bindings/templates/methods.cpp:260: {% macro
throw_arity_type_error(method, minimum_number_of_required_arguments) %}
Naming-wise, I'd prefer 'number_of_required_arguments',
without the 'minimum_'
('minimum_' is really only applicable to overloads),
though it's not a big deal.

[haraken, 2014-04-02 07:01:19]

LGTM with Nils' comments addressed.

[fs, 2014-04-02 07:13:45]

Thanks for reviews! (It was a [pleasant] surprise at this time of day =))

https://codereview.chromium.org/221073003/diff/1/Source/bindings/templates/me...
File Source/bindings/templates/methods.cpp (right):

https://codereview.chromium.org/221073003/diff/1/Source/bindings/templates/me...
Source/bindings/templates/methods.cpp:12: {{throw_arity_type_error(method,
method.number_of_required_arguments) | indent(8)}}
On 2014/04/02 06:47:37, Nils Barth wrote:
> The 'indent' is not necessary, as this is one line.
> Also, since it's one line, could you move the ';' out of the macro
> and into this line, to make it clear that it's a one-liner?
> 
> Now documented at:
> https://sites.google.com/a/chromium.org/dev/developers/jinja#TOC-Style

Done and done.

https://codereview.chromium.org/221073003/diff/1/Source/bindings/templates/me...
Source/bindings/templates/methods.cpp:260: {% macro
throw_arity_type_error(method, minimum_number_of_required_arguments) %}
On 2014/04/02 06:47:37, Nils Barth wrote:
> Naming-wise, I'd prefer 'number_of_required_arguments',
> without the 'minimum_'
> ('minimum_' is really only applicable to overloads),
> though it's not a big deal.

Done.

[Nils Barth (inactive), 2014-04-02 07:26:41]

(Thanks for style fixes!)

[fs, 2014-04-02 08:22:59]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-04-02 08:23:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/221073003/20001

[commit-bot: I haz the power, 2014-04-02 09:34:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 09:34:37]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[fs, 2014-04-02 10:28:14]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-04-02 10:28:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/221073003/20001

[commit-bot: I haz the power, 2014-04-02 11:42:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 11:42:20]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[fs, 2014-04-02 12:08:44]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-04-02 12:08:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/221073003/20001

[commit-bot: I haz the power, 2014-04-02 13:20:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 13:20:48]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[fs, 2014-04-02 13:30:32]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-04-02 13:30:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/221073003/20001

[commit-bot: I haz the power, 2014-04-02 14:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 14:42:08]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[fs, 2014-04-02 14:56:42]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-04-02 14:56:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/221073003/20001

[commit-bot: I haz the power, 2014-04-02 16:05:58]

Change committed as 170666